Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Danfoss Ally Thermostat #1737

Merged
merged 13 commits into from
Nov 26, 2020
Merged

Add Danfoss Ally Thermostat #1737

merged 13 commits into from
Nov 26, 2020

Conversation

asgothian
Copy link
Contributor

Added Danfoss Ally Thermostat

Added Danfoss Ally Thermostat
ae and others added 6 commits November 14, 2020 16:06
@asgothian
Copy link
Contributor Author

Fixed all the comments from the review. Note that the exposes are added but not tested as i am not using Home Assistant.

Also added a converter for the Bitron 902010/29 outdoor siren. This was tested earlier today and should work fine. It can only be used to report on battery error or to send an alert to the siren.

@Zeddy-
Copy link

Zeddy- commented Nov 17, 2020

Hi, the Ally is really slow to respond to setpoint attribute changes, and according to their documentation you should be able to make it move immediately with this command:

image

So what i did was added this to zigbee-herdsmans cluster.js hvacthermostat:

hvacThermostat: {
        ID: 513,
        commands: {
            danfossSetpointCommand: {
		ID: 64,
		parameters: [
                    { name: 'setpointType', type: dataType_1.default.enum8 },
                    { name: 'HeatingSetpoint', type: dataType_1.default.uint16 },
                ],
	    },
        }
        }

and this to zigbee-herdsman-converters toZigbee.js:

    danfoss_setpoint_command: {
        key: ['danfoss_setpoint_command'],
        convertSet: async (entity, key, value, meta) => {
            const payload = {setpointType: value.setpointtype, HeatingSetpoint: value.heatingsetpoint};
            await entity.command('hvacThermostat', 'danfossSetpointCommand', payload, getOptions(meta.mapped, entity));
        },
    },

and under devices.js

 toZigbee: [
          tz.danfoss_setpoint_command
        ],
   

I am able to execute this command, without errors, but it has no effect. Any Ideas? :)

@asgothian
Copy link
Contributor Author

Can you link the documentation this was taken from ? I only had access to the cluster definition when building the support. I found that my thermostat reacted reasonably quickly (within 30 seconds) to a set point change.

Also - I was able to confirm that the thermostat does not accept any mode change commands. The one thing I am still uncertain of is the function of the “heat available” datapoint.

A.

@asgothian
Copy link
Contributor Author

Without this document, i will have to concede that i have done what i can.

How are the chances of this getting merged ?

@Koenkk Koenkk merged commit 1ffac3a into Koenkk:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants