Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
future
is causing problems because we are bundling dependencies statically for a distribution that targets py2+py3.It was introduced because of #4 in PR #5
Hard to believe that someone would bundle dependencies, but in our case it's very relevant because we distribute python packages for net-less installation with everything bundled in. We can't use django-q for our packages because
future
is raising exceptions when loaded on Python 3:learningequality/kolibri#1797
Anyways, it wasn't used in more than 1 single instance of
from builtins import range
.Here are some other advantages:
future
redefines and monkey patches sys.modules for all other packages, perhaps not nice!future
was missing in README.rst descriptionI've fixed some more cases where
range
wasn't loaded in a backwards compatible way. You can say that even thoughfuture
was added as a dependency, it wasn't used in a couple of cases where it should have (test code).Reference
There was only one case of accessing something redefined by
futures
library.