This repository has been archived by the owner on Feb 7, 2022. It is now read-only.
Making the templating component an optional dependency #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It already basically was, but we were requiring it.
weaverryan
force-pushed
the
remove-templating-dependency
branch
from
2506a76 to
02d9f8b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It already basically was, but we were requiring it. This could be seen as a minor BC break, butthe service in question is only NOT registered if you don't have the
symfony/templatingcomponent installed... and it's whole purpose in life is to integrate with that component.Cheers!