Fix for issue #519, unnecessary check for validatable observables #529

brettmorien · 2015-01-28T19:30:46Z

Still learning how to git properly, so here's a different pull request for issue #519.

crissdev · 2015-01-28T21:04:19Z

test/validation-ui-tests.js

@@ -625,6 +625,74 @@ QUnit.test('Issue #44 - Validation Element - Is Invalid Test', function(assert)

 });

+QUnit.test('Validatable can become non-validatable', 0, function(assert) {


Instead of using this syntax (0 expectations), why not add an assert at the end of the test, like assert.equal(ko.validation.utils.isValidatable(false), false); IMO, It would better describe the test.

It was an accident leaving this test behind. Removing it as redundant and incomplete.

…h validationElement and validationMessage in markup. #519 Additional unit tests for issue #519 Undo updates to package.json Rejiggered unit tests for issue #519 to be more thorough. Fix unit tests.

crissdev · 2015-01-30T15:01:05Z

Looks good. Can I merge this or you want to make further changes?

brettmorien · 2015-01-30T17:01:50Z

Done and ready to go. Merge away.

validationElement and validationMessage bindings throw if observable is not validatable.

crissdev · 2015-01-30T19:19:17Z

landed in 8409e9a

brettmorien · 2015-01-30T19:34:23Z

Sweet. Thanks!

crissdev · 2015-01-30T20:02:26Z

At this point 2.0.2 is ready. Unless there's any urgent bug to be fixed. Going to update the NuGet package also for this release - most probably on Monday.
FYI, the file names for NuGet package will change to be the same as for npm and bower. This might be a bit frustrating for some users but I think it's better do this change now than later.

brettmorien mentioned this pull request Jan 28, 2015

Fix for issue #519, unnecessary check for validatable observables #523

Closed

crissdev reviewed Jan 28, 2015
View reviewed changes

Fix for issue #519, unnecessary check for validatable observables wit…

97d578a

…h validationElement and validationMessage in markup. #519 Additional unit tests for issue #519 Undo updates to package.json Rejiggered unit tests for issue #519 to be more thorough. Fix unit tests.

crissdev added a commit that referenced this pull request Jan 30, 2015

Merge pull request #529 from askheaves/master

d0a16f7

validationElement and validationMessage bindings throw if observable is not validatable.

crissdev closed this Jan 30, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for issue #519, unnecessary check for validatable observables #529

Fix for issue #519, unnecessary check for validatable observables #529

brettmorien commented Jan 28, 2015

crissdev Jan 28, 2015

brettmorien Jan 28, 2015

crissdev commented Jan 30, 2015

brettmorien commented Jan 30, 2015

crissdev commented Jan 30, 2015

brettmorien commented Jan 30, 2015

crissdev commented Jan 30, 2015

		@@ -625,6 +625,74 @@ QUnit.test('Issue #44 - Validation Element - Is Invalid Test', function(assert)

		});

		QUnit.test('Validatable can become non-validatable', 0, function(assert) {

Fix for issue #519, unnecessary check for validatable observables #529

Fix for issue #519, unnecessary check for validatable observables #529

Conversation

brettmorien commented Jan 28, 2015

crissdev Jan 28, 2015

Choose a reason for hiding this comment

brettmorien Jan 28, 2015

Choose a reason for hiding this comment

crissdev commented Jan 30, 2015

brettmorien commented Jan 30, 2015

crissdev commented Jan 30, 2015

brettmorien commented Jan 30, 2015

crissdev commented Jan 30, 2015