Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency to knockout.validation instead of knockout. #517

Merged
merged 1 commit into from
Jan 23, 2015
Merged

Add dependency to knockout.validation instead of knockout. #517

merged 1 commit into from
Jan 23, 2015

Conversation

viceice
Copy link

@viceice viceice commented Jan 23, 2015

Closes #509

@crissdev
Copy link
Member

Looks good. 👍
Once I have some time for it will merge it.

@crissdev crissdev self-assigned this Jan 23, 2015
@viceice
Copy link
Author

viceice commented Jan 23, 2015

Should i squash the commits?

@crissdev
Copy link
Member

If you want to, sure. It will speed up things. You may also want to replace knockout with knockout-validation on lines 8 and 11 :-)

@viceice
Copy link
Author

viceice commented Jan 23, 2015

ok, i will do it.

@viceice
Copy link
Author

viceice commented Jan 23, 2015

Like this?

@crissdev
Copy link
Member

Yeap. To further prevent a rebase on my end, please rebase you last commit (reword) and change the commit message to just "Fix #509 - Localization loading randomly breaks when using requirejs" - to make it similar to other commits. And that should be it.

@viceice
Copy link
Author

viceice commented Jan 23, 2015

Ok. 😄

When do you think you will release a new version?

@crissdev
Copy link
Member

Thanks a lot.

For upcoming releases it worths checking out https://github.com/Knockout-Contrib/Knockout-Validation/milestones

crissdev added a commit that referenced this pull request Jan 23, 2015
Add dependency to knockout.validation instead of knockout.
@crissdev crissdev merged commit 9a17a1f into Knockout-Contrib:master Jan 23, 2015
@viceice
Copy link
Author

viceice commented Jan 23, 2015

No problem. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localization loading randomly breaks when using requirejs
2 participants