Some tiny fixes #39
Merged
Some tiny fixes #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a fix to adjust the KL divergence when exaggeration is turned on. See discussion with Pavlin in #37. |
…, and hence gave nan for cost when late exaggeration was not being used
…o longer used for timing
|
Really great changes, thanks so much @dkobak!! You'll see that I made one quick change as I was getting nan cost when late exaggeration was not being used, but it was very minor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) Progress bar width set to 60 in the second place it occurs; (2) removed superfluous condition check when displaying progress; (3) error message when using FFT and no_dims>2 as per #34; (4) mention installation issue #35 in the readme; (5) mention python wrapper in the readme :)
#35 and #34 could be closed then.