Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PC-686 Use await using for proper disposal of objects #1046

Merged
merged 1 commit into from
Feb 6, 2025

Use await using for proper disposal of objects

bd8e120
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

PC-686 Use await using for proper disposal of objects #1046

Use await using for proper disposal of objects
bd8e120
Select commit
Loading
Failed to load commit list.
GitHub Actions / dotnet tests succeeded Feb 6, 2025 in 0s

100 passed, 0 failed and 2 skipped

Tests passed successfully

✅ testresults/_buildkitsandbox_2025-02-06_09_34_45.trx

102 tests were completed in 5s with 100 passed, 0 failed and 2 skipped.

Test suite Passed Failed Skipped Time
Kiss.Bff.Test.AuthorizationCheckTests 16✅ 2⚪ 151ms
Kiss.Bff.Test.BerichtenControllerTests 5✅ 232ms
Kiss.Bff.Test.CategorienControllerTests 1✅ 32ms
Kiss.Bff.Test.GespreksresultatenUnitTests 8✅ 77ms
Kiss.Bff.Test.GetFaqTests 1✅ 60ms
Kiss.Bff.Test.GetFeaturedCountControllerTests 1✅ 18ms
Kiss.Bff.Test.KanalenTests 7✅ 46ms
Kiss.Bff.Test.LinksControllerUnitTests 7✅ 32ms
Kiss.Bff.Test.MarkeerGelezenControllerTests 2✅ 32ms
Kiss.Bff.Test.MigrationCompletenessTest 1✅ 458ms
Kiss.Bff.Test.MigrationDownAndUpTest 1✅ 810ms
Kiss.Bff.Test.PostKlantContactenCustomProxyTests 6✅ 87ms
Kiss.Bff.Test.ReadContactmomentenDetailsTests 2✅ 14ms
Kiss.Bff.Test.ReadContactverzoekenVragenSetsTests 2✅ 20ms
Kiss.Bff.Test.SearchBerichtenControllerTests 1✅ 75ms
Kiss.Bff.Test.SendFeedbackTest 1✅ 209ms
Kiss.Bff.Test.SkillsControllerUnitTests 8✅ 47ms
Kiss.Bff.Test.UserExtensionsTests 9✅ 2ms
Kiss.Bff.Test.VerwerkingMiddlewareUnitTests 1✅ 30ms
Kiss.Bff.Test.WriteContactmomentDetailsTests 2✅ 65ms
Kiss.Bff.Test.WriteContactverzoekenVragenSetsTests 3✅ 28ms
Kiss.Bff.Test.ZaakGerichtWerkenUnitTests 1✅ 52ms
Kiss.Bff.Test.Zaaksysteem.GetZaaksysteemDeeplinkConfigTest 2✅ 8ms
Kiss.Bff.Test.Zaaksysteem.GetZakenTests 8✅ 78ms
Kiss.Bff.Test.Zaaksysteem.ZaaksysteemConfigTests 2✅ 4ms
Kiss.Bff.Test.Zaaksysteem.ZaaksysteemProxyTests 2✅ 8ms

✅ Kiss.Bff.Test.AuthorizationCheckTests

✅ CallingEnpointsWithoutCredetialsShouldResultInAUnauthorizedResponse (/api/contactmomentendetails?id=1)
✅ CallingEnpointsWithoutCredetialsShouldResultInAUnauthorizedResponse (/api/faq)
✅ CallingEnpointsWithoutCredetialsShouldResultInAUnauthorizedResponse (/api/internetaak/api/version/objects,post)
✅ CallingEnpointsWithoutCredetialsShouldResultInAUnauthorizedResponse (/api/KanaalToevoegen,post)
✅ CallingEnpointsWithoutCredetialsShouldResultInAUnauthorizedResponse (/api/postcontactmomenten,post)
✅ CallingEnpointsWithoutCredetialsShouldResultInAUnauthorizedResponse (/api/zaaksysteem/deeplinkconfig)
✅ TestAuthorizationOfManagementInformatieEndpoint
✅ TestAuthorizeAttribute (Kiss.Bff.Beheer.Verwerking.GetVerwerkingsLogs,Get,System.Type[])
✅ TestAuthorizeAttribute (Kiss.Bff.Intern.Gespreksresultaten.Features.GespreksresultatenController,DeleteGespreksresultaat,System.Type[])
✅ TestAuthorizeAttribute (Kiss.Bff.Intern.Gespreksresultaten.Features.GespreksresultatenController,PostGespreksresultaat,System.Type[])
✅ TestAuthorizeAttribute (Kiss.Bff.Intern.Gespreksresultaten.Features.GespreksresultatenController,PutGespreksresultaat,System.Type[])
✅ TestAuthorizeAttribute (Kiss.Bff.Intern.Links.Features.LinksController,DeleteLink,System.Type[])
✅ TestAuthorizeAttribute (Kiss.Bff.Intern.Links.Features.LinksController,PostLink,System.Type[])
✅ TestAuthorizeAttribute (Kiss.Bff.Intern.Links.Features.LinksController,PutLink,System.Type[])
⚪ TestAuthorizeAttribute (Kiss.Bff.Intern.Seed.Features.SeedController,SeedCheck,System.Type[])
⚪ TestAuthorizeAttribute (Kiss.Bff.Intern.Seed.Features.SeedController,SeedStart,System.Type[])
✅ TestAuthorizeAttribute (Kiss.Bff.NieuwsEnWerkinstructies.Features.SkillsController,PostSkill,System.Type[])
✅ TestAuthorizeAttribute (Kiss.Bff.NieuwsEnWerkinstructies.Features.SkillsController,PutSkill,System.Type[])

✅ Kiss.Bff.Test.BerichtenControllerTests

✅ DeleteBericht_ReturnsNoContentResult_WhenBerichtIsDeleted
✅ GetBericht_ReturnsOkObjectResult_WithBerichtViewModel
✅ GetBerichten_ReturnsOkResult_WithBerichtOverviewModels
✅ PostBericht_ReturnsCreatedAtActionResult_WithCreatedBerichtViewModel
✅ PutBericht_ReturnsNoContentResult_WhenBerichtIsUpdated

✅ Kiss.Bff.Test.CategorienControllerTests

✅ GetLinks_ReturnsOkResult_WithCategories

✅ Kiss.Bff.Test.GespreksresultatenUnitTests

✅ DeleteGespreksresultaat_WithInvalidId_ReturnsNoContent
✅ DeleteGespreksresultaat_WithValidId_ReturnsNoContent
✅ GetGespreksresultaat_ReturnsGespreksresultaat
✅ GetGespreksresultaat_WithInvalidId_ReturnsNotFound
✅ GetGespreksresultaten_ReturnsOkResultWithGespreksresultaten
✅ PostGespreksresultaat_ReturnsCreatedResponseWithGespreksresultaat
✅ PutGespreksresultaat_WithInvalidId_ReturnsNotFound
✅ PutGespreksresultaat_WithValidId_ReturnsNoContent

✅ Kiss.Bff.Test.GetFaqTests

✅ Get_ReturnsTopQuestions

✅ Kiss.Bff.Test.GetFeaturedCountControllerTests

✅ GetCount_ReturnsActionResult_WithFeaturedCount

✅ Kiss.Bff.Test.KanalenTests

✅ DeleteLink_WithInvalidId_ReturnsNotFoundResult
✅ DeleteLink_WithValidId_ReturnsNoContent
✅ Get_WithInvalidId_ReturnsNotFoundResult
✅ Get_WithValidId_ReturnsKanaal
✅ Post_WithValid_ReturnsCreatedResult
✅ Put_WithValidId_ReturnsNoContent
✅ PutLink_WithInvalidId_ReturnsNotFoundResult

✅ Kiss.Bff.Test.LinksControllerUnitTests

✅ DeleteLink_WithInvalidId_ReturnsNotFoundResult
✅ DeleteLink_WithValidId_ReturnsNoContent
✅ GetLink_WithInvalidId_ReturnsNotFoundResult
✅ GetLink_WithValidId_ReturnsLink
✅ PostLink_WithValidLink_ReturnsCreatedResultWithLink
✅ PutLink_WithInvalidId_ReturnsNotFoundResult
✅ PutLink_WithValidId_ReturnsNoContent

✅ Kiss.Bff.Test.MarkeerGelezenControllerTests

✅ MarkeerGelezen_ExistingEntity_IsGelezenFalse_RemovesGelezen
✅ MarkeerGelezen_ExistingEntity_UpdatesGelezenOp

✅ Kiss.Bff.Test.MigrationCompletenessTest

✅ TestIfWeForgotToAddAMigration

✅ Kiss.Bff.Test.MigrationDownAndUpTest

✅ MigrateUpAndDown

✅ Kiss.Bff.Test.PostKlantContactenCustomProxyTests

✅ CheckIfActorExists_ShouldReturnActorUuid_WhenActorExists
✅ CheckIfActorExists_ShouldReturnNull_WhenActorDoesNotExist
✅ LinkActorWithKlantContact_ShouldReturnFalse_WhenLinkFails
✅ LinkActorWithKlantContact_ShouldReturnTrue_WhenLinkedSuccessfully
✅ PostActoren_ShouldReturnCreatedActorUuid_WhenSuccessful
✅ PostKlantContact_ShouldReturnKlantContactUuid_WhenSuccessful

✅ Kiss.Bff.Test.ReadContactmomentenDetailsTests

✅ Get_InvalidId_ReturnsNotFound
✅ Get_ValidId_ReturnsOk

✅ Kiss.Bff.Test.ReadContactverzoekenVragenSetsTests

✅ Get_ContactVerzoekVragenSetsExist_ReturnsOkWithList
✅ Get_NoContactVerzoekVragenSets_ReturnsOkWithEmptyList

✅ Kiss.Bff.Test.SearchBerichtenControllerTests

✅ GetBerichten_ReturnsSearchResults

✅ Kiss.Bff.Test.SendFeedbackTest

✅ BuildEmailBody_ContainsUserName

✅ Kiss.Bff.Test.SkillsControllerUnitTests

✅ DeleteSkill_ReturnsNoContentResult_WithValidId
✅ DeleteSkill_ReturnsNotFoundResult_WithInvalidId
✅ GetSkill_ReturnsNotFoundResult_WithInvalidId
✅ GetSkill_ReturnsOkResult_WithValidId
✅ GetSkills_ReturnsOkResult_WithSkills
✅ PostSkill_ReturnsCreatedAtActionResult_WithValidModel
✅ PutSkill_ReturnsNoContentResult_WithValidId
✅ PutSkill_ReturnsNotFoundResult_WithInvalidId

✅ Kiss.Bff.Test.UserExtensionsTests

✅ GetEmail_UserHasJwtEmailClaim_ReturnsJwtEmailClaim
✅ GetEmail_UserHasPreferredUserNameClaim_ReturnsPreferredUserNameClaim
✅ GetFirstName_UserHasJwtGivenNameClaim_ReturnsJwtGivenNameClaim
✅ GetId_UserHasNameIdentifier_ReturnsNameIdentifier
✅ GetId_UserHasObjectIdentifier_ReturnsObjectIdentifier
✅ GetLastName_UserHasIdentityName_ReturnsIdentityName
✅ GetLastName_UserHasJwtFamilyNameClaim_ReturnsJwtFamilyNameClaim
✅ GetLastName_UserHasJwtNameClaim_ReturnsJwtNameClaim
✅ GetMedewerkerIdentificatie_ReturnsJsonObjectWithTruncatedValues

✅ Kiss.Bff.Test.VerwerkingMiddlewareUnitTests

✅ SendAsync_LogsHttpRequestToDatabase

✅ Kiss.Bff.Test.WriteContactmomentDetailsTests

✅ Post_ModelWithExistingId_UpdatesExistingEntity
✅ Post_ValidModel_ReturnsOk

✅ Kiss.Bff.Test.WriteContactverzoekenVragenSetsTests

✅ DeleteContactVerzoekVragenSet_ReturnsOkResult_WhenModelIsDeleted
✅ PostContactVerzoekVragenSet_ReturnsOkResult_WhenModelIsAdded
✅ PutContactVerzoekVragenSet_ReturnsOkResult_WhenModelIsUpdated

✅ Kiss.Bff.Test.ZaakGerichtWerkenUnitTests

✅ GenerateToken_ReturnsValidToken

✅ Kiss.Bff.Test.Zaaksysteem.GetZaaksysteemDeeplinkConfigTest

✅ Get_config_returns_500_if_config_is_missing
✅ GetConfigReturnsCorrectVariables

✅ Kiss.Bff.Test.Zaaksysteem.GetZakenTests

✅ GetZaken_correctly_handles_missing_config
✅ GetZaken_correctly_proxies_400_status_code
✅ GetZaken_correctly_proxies_unreachable_host
✅ GetZaken_sets_zaaksysteemId
✅ GetZaken_uses_ordering_parameter_for_sorting_ascending
✅ GetZaken_uses_ordering_parameter_for_sorting_descending
✅ GetZaken_with_kvknummer_and_rsin_queries_by_kvknummer_if_specified_in_config
✅ GetZaken_with_kvknummer_and_rsin_queries_by_rsin_by_default

✅ Kiss.Bff.Test.Zaaksysteem.ZaaksysteemConfigTests

✅ Legacy_environment_variables_are_parsed_as_zaaksysteem_config
✅ New_list_environment_variables_are_parsed_as_zaaksysteem_config

✅ Kiss.Bff.Test.Zaaksysteem.ZaaksysteemProxyTests

✅ Proxy_returns_500_if_config_is_missing
✅ Proxy_returns_correct_result
View more details on GitHub Actions