STYLE: Rename ITK_DISALLOW_COPY_AND_ASSIGN to ITK_DISALLOW_COPY_A… #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes changes made in #2053. ITK_DISALLOW_COPY_AND_ASSIGN will be used if ITK_FUTURE_LEGACY_REMOVE=OFF.
mseng10
force-pushed
the
rename-disallow-copy-and-assign
branch
from
1e4c415 to
6dab845
Compare
mseng10
changed the title
hjmjohnson
approved these changes
Dec 30, 2020
|
@dzenanz This is ready for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes changes made in #2053. Essentially,
ITK_DISALLOW_COPY_AND_ASSIGNhas been changed toITK_DISALLOW_COPY_AND_MOVEto more accurately convey the actions taking place.ITK_DISALLOW_COPY_AND_ASSIGNwill only be used ifITK_FUTURE_LEGACY_REMOVE=OFF.NOTE: These changes will cause the GitHub Actions to break, because they currently build
ITK v5.1.0. The errors persist withv5.1.1as well (will update to newest version in separate PR). When tested locally againstmaster, I get all tests to pass. The case is the same for the remaining 39 remote modules.