Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement user creation REST API. #2

Merged
merged 1 commit into from
Oct 16, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion redash/handlers/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from redash.handlers.events import EventResource
from redash.handlers.queries import QueryForkResource, QueryRefreshResource, QueryListResource, QueryRecentResource, QuerySearchResource, QueryResource, MyQueriesResource
from redash.handlers.query_results import QueryResultListResource, QueryResultResource, JobResource
from redash.handlers.users import UserResource, UserListResource, UserInviteResource, UserResetPasswordResource
from redash.handlers.users import UserResource, UserListResource, UserInviteResource, UserResetPasswordResource, UserCreateResource
from redash.handlers.visualizations import VisualizationListResource
from redash.handlers.visualizations import VisualizationResource
from redash.handlers.widgets import WidgetResource, WidgetListResource
Expand Down Expand Up @@ -89,6 +89,7 @@ def json_representation(data, code, headers=None):
api.add_org_resource(UserResource, '/api/users/<user_id>', endpoint='user')
api.add_org_resource(UserInviteResource, '/api/users/<user_id>/invite', endpoint='user_invite')
api.add_org_resource(UserResetPasswordResource, '/api/users/<user_id>/reset_password', endpoint='user_reset_password')
api.add_org_resource(UserCreateResource, '/api/users/create', endpoint='users_create')

api.add_org_resource(VisualizationListResource, '/api/visualizations', endpoint='visualizations')
api.add_org_resource(VisualizationResource, '/api/visualizations/<visualization_id>', endpoint='visualization')
Expand Down
31 changes: 31 additions & 0 deletions redash/handlers/users.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,37 @@ def post(self):

return d

class UserCreateResource(BaseResource):
@require_admin
def post(self):
req = request.get_json(force=True)
require_fields(req, ('name', 'email', 'password'))

user = models.User(org=self.current_org,
name=req['name'],
email=req['email'],
group_ids=[self.current_org.default_group.id])
user.hash_password(req['password'])

try:
models.db.session.add(user)
models.db.session.commit()
except IntegrityError as e:
if "email" in e.message:
abort(400, message='Email already taken.')

abort(500)

self.record_event({
'action': 'create',
'timestamp': int(time.time()),
'object_id': user.id,
'object_type': 'user'
})

d = user.to_dict()

return d

class UserInviteResource(BaseResource):
@require_admin
Expand Down