Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transparent urlbar with ATBC #35

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

PixsaOJ
Copy link
Contributor

@PixsaOJ PixsaOJ commented Mar 17, 2024

fixes #16

Fixes issue of URLbar sometimes being transparent.

If you are using ATBC extension to have different theme for each website and you also use popup URLbar, then you might need this fix.

This just sets the colors, but it might not match with link suggestion box's background (I'm talking about whats under URLbar).
You would also need to set this settings in extension preferences, here is mine:

image

Notice that Toolbar background setting is 1 tick higher than tab bar setting.

image

Tested on FR 123.0.1

Copy link
Contributor

@jacksonsamuelmoore jacksonsamuelmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic - fixes the transparency issue! However I tested and found that there's a second instance of --toolbar-bgcolor being used just below this that also needs to be changed, otherwise the URL bar suggestions container colour might not match the URL bar colour like so:

image

@PixsaOJ
Copy link
Contributor Author

PixsaOJ commented Mar 18, 2024

I noticed that --toolbar-bgcolor and did not know what it was for. I am able to adjust that using extension settings.

I will go ahead and include that as well

@KiKaraage KiKaraage merged commit bb6f2b7 into KiKaraage:main Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--toolbar-bgcolor makes the url suggestion bar have transparent background
3 participants