Added note about IOR and roughness for transmission #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abwood
approved these changes
Sep 25, 2020
|
This PR addresses: #1718 (comment) |
emackey
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't consider this a spec change so much as increased clarity, as this is a natural conclusion to draw from the physics. However, calling it out is important as it might not be obvious that IOR would affect the amount of roughness blur.
I purposefully put "unless otherwise specified by another extension" because this will be handled differently when using the volume extension since at that point the transmission surface becomes single-sided (entering the volume).