-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KHR_materials_clearcoat extension branch. #1740
KHR_materials_clearcoat extension branch. #1740
Conversation
Thanks Norbert. Acknowledgments, Overview, and Appendix all say |
It was explicitly wanted, that the 3D formats group is doing this. Actually, as Alexey is the specification master, maybe outreach to him. |
Thanks for splitting #1677. Would be great if we could add a bit more detail about how the clearcoat BRDF looks like and how layering works. I tried to sketch something which fits the rewrite of Appendix B of the main spec (#1717). Feel free to add it to the PR or tell me if you want me to open a PR against the ux3d repo.
|
Forgot to mention, the text above is basically a replacement for the paragraphs that define It changes the equations a bit to make it reciprocal (VdotN and LdotN are now both part of the base weight), but in the end it permits to drop LdotN (which results in exactly the same math as before). |
This is a great extension. The parameters as defined are just great. |
At the last meeting, Alex Wood and I offered to update the Overview section and try to polish this up enough for merge. But I was unable to push to the UX3D repo, so I had to move the branch into the main repo here. Therefore I must close this PR, and ask everyone to continue the conversation in #1756. Thanks @UX3D-nopper and everyone who has contributed here, please see the updates in #1756. |
No description provided.