Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reference links #67

Merged
merged 7 commits into from
Nov 30, 2021
Merged

Conversation

javagl
Copy link
Contributor

@javagl javagl commented Nov 22, 2021

To be merged after #66

Fixes #59

Done by a "replace all" - to be reviewed!
Some links had not been captured by the first replace-all pass.

Some anchors used a different pattern on GitHub than they use
on the Khronos registry page.
@javagl
Copy link
Contributor Author

javagl commented Nov 22, 2021

@emackey This is the third of three pull requests

They build on top of each other: The first ones are rather simple and small, and this one is rather technical (in that it mainly consisted of a "replace all"), so I thought that it wouldn't make much sense to have them as separate PRs, always starting from master.

Depending on the preferred process, it could make sense to review and merge this one, implicitly dropping the two other ones.

Copy link
Member

@emackey emackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few URL tweaks, but this is great @javagl. Thanks!

As suggested in the PR review

Co-authored-by: Ed Mackey <[email protected]>
@javagl
Copy link
Contributor Author

javagl commented Nov 30, 2021

Thanks @emackey ! I had done a "full text search", and a largely automated replace, with manual tweaks for some critical ones (e.g. some of these #nested-anchors-with-dashes). I have no idea how I missed the ones that still obviously pointed to GitHub, and things like the bufferView vs. bufferview are ... subtle, but I think that most if not all links should be correct now. (If someone spots a broken one, that could be a dedicated issue/PR).

Copy link
Member

@emackey emackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a big improvement. I'm going to merge it now and then do another pass looking for any stragglers.

@emackey emackey merged commit 0167273 into KhronosGroup:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update links to point to the Khronos glTF registry
2 participants