Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of open issues for the generic glTF tutorial #5

Closed
15 tasks
javagl opened this issue Oct 20, 2016 · 1 comment
Closed
15 tasks

List of open issues for the generic glTF tutorial #5

javagl opened this issue Oct 20, 2016 · 1 comment

Comments

@javagl
Copy link
Contributor

javagl commented Oct 20, 2016

The generic glTF tutorial in #1 still has some open issues that I will list here, straight from my "TODO" list. (If appropriate, some of them might be pulled out into dedicated issues).

  • Add the legalese statements for using the Khronos logos....
  • Consider adding an overview for recommended OpenGL/WebGL tutorials in JavaScript/C++/Java...
  • In gltfTutorial_002_BasicGltfStructure.md, mention embedded and binary glTF
  • Make the formatting (backticking) consistent. Should it be "The mesh contains a mesh primitive", or "The mesh contains a meshPrimitive"? Which is considered more readable?
  • Make the naming pattern for example JSON consistent. Right now, user-defined names are named like "exampleMesh". Should this be "mesh0", as this is usually written by the export tools?
  • The section "Image data in images" in gltfTutorial_002_BasicGltfStructure.md mentioned the image formats, internalFormat etc. This should be explained in gltfTutorial_005_MeshesTexturesImagesSamplers.md! See also glTF issue 728
  • In gltfTutorial_004_ScenesNodesCamerasAnimations.md, at "Animation samplers", mention that the interpolation there is LINEAR, and mention the other interpolation types. Particularly, mention SLERP with implementation notes for JavaScript/Java/C++...
  • In gltfTutorial_006_MaterialsTechniquesProgramsShaders.md, mention the node property, and the "context awareness" of the semantics when no node is given (see https://github.com/KhronosGroup/glTF/tree/master/specification#semantics )
  • In gltfTutorial_006_MaterialsTechniquesProgramsShaders.md, mention technique.states
  • Consider some shameless self-promotion of https://javagl.github.io/GLConstantsTranslator/GLConstantsTranslator.html
  • Consider adding more images:
    • For the "Local and global transforms" in gltfTutorial_004_ScenesNodesCamerasAnimations.md
    • For the buffer->bufferView->accessor structure in gltfTutorial_007_BuffersBufferViewsAccessors.md
    • ...
  • Some images have to be improved: gltfStructure.pngshould say ".vert/.frag files" instead of ".glsl files". The technique.png looks a bit confusing.

For some points, it is not clear whether they should be described generically, in the tutorial, or whether they should be part of a dedicated section showing the "Implementation of a renderer" - for example:

  • In gltfTutorial_006_MaterialsTechniquesProgramsShaders.md, there should be a link to the implementation section, showing how the "Techniqe parameter values" are eventually passed to OpenGL.
  • In gltfTutorial_006_MaterialsTechniquesProgramsShaders.md, the "Implementation notes" for the program compilation are somewhat extensive, and would fit better into the implementation section
  • In gltfTutorial_004_ScenesNodesCamerasAnimations.md, consider adding a summary "Playing the animations". However, such a section could better fit into the implementation section, which shows how the pieces of information are finally assembled into a renderer
@javagl
Copy link
Contributor Author

javagl commented Dec 19, 2016

Most of these points have either been tackled or become obsolete with the changes that have been done after the first pull request was sent out. I'll close this for now. Individual points can be brought up as dedicated issues, if necessary.

@javagl javagl closed this as completed Dec 19, 2016
pjcozzi pushed a commit that referenced this issue Nov 26, 2017
Minor fix of broken anchor to 8th tutorial
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant