account for IOR when computing f0 #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emackey
reviewed
Apr 16, 2020
| // For an index of refraction of 1.5, this results the known default value of 0.04 reflectivity for dielectrics. | ||
| float f0_ior(float ior) | ||
| { | ||
| float f0 = sq((ior - 1.0) / (ior + 1.0)); |
There was a problem hiding this comment.
Since IOR is uniform, this per-fragment computation seems expensive. Could the app compute this value and pass it in as uniform?
There was a problem hiding this comment.
Yes ... and this is the reason why I do not want this extension for reflection, as this information is already available in the Metallic-Roughness material - or for more control - in the specular one. This would be the third(!) possibility to define F0.
There was a problem hiding this comment.
But please compare to KhronosGroup/glTF#1718 and KhronosGroup/glTF#1719 as well.
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.