Skip to content
This repository was archived by the owner on Dec 22, 2023. It is now read-only.

Added "scene" property to simple test models #242

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

javagl
Copy link
Contributor

@javagl javagl commented Dec 11, 2019

According to the specification, the runtime is not required
to render anything when the scene property is undefined.

Fixes #240

According to the specification, the runtime is not required
to render anything when the scene property is undefined.
@emackey
Copy link
Member

emackey commented Dec 11, 2019

Also fixes #166 I believe.

@javagl
Copy link
Contributor Author

javagl commented Dec 11, 2019

@emackey In some way, yes, but 166 also considered adding an example with multiple scenes. (I think there is no sample right now with multiple scenes, so I'm currently creating one - as usual for the "simple" test models, it's a trivial one, just to test which viewers choke on that (and in which way...))

@emackey
Copy link
Member

emackey commented Dec 11, 2019

@javagl Actually I'm not sure the WG wants an official sample until we know what the plan is for multiple scenes. There's an issue open for considering deprecating multiple scenes. KhronosGroup/glTF#1542

@emackey emackey merged commit 130fe58 into KhronosGroup:master Dec 11, 2019
@javagl
Copy link
Contributor Author

javagl commented Dec 11, 2019

@emackey Thanks for that hint. I also just had a look at the issue, but have not yet read through the discussion there - it seems like this is targeting glTF-next, and so one might consider adding the sample anyhow. But in doubt, for now, it resides in a branch at https://github.com/javagl/glTF-Sample-Models/tree/MultipleScenes , and 166 can probably be closed for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

According to the specs, TriangleWithoutIndices should not render anything
2 participants