validation_layer_generator: do not check static array addresses #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generator creates the same validation code for a static array of structs than for a pointer to a struct (used for dynamically allocated arrays): it first checks if the content of the member is not null. Given that static array addresses are always not null, GCC (12.2.1) and CLANG (16.0.1) emit pointer-bool-conversion warnings.
|
|
|
Oh so that's why it's making that warning... I hadn't had a chance to look into it but I had seen the warning. Thanks, this is great! Would you mind putting a changelog fragment in changes/sdk/pr.399.gh.OpenXR-SDK-Source.md ? |
rpavlik
approved these changes
Apr 25, 2023
rpavlik
added
in layers
needs changelog fragment
What's that ? Ok, I'll have a look. |
|
Done. I hope that it conforms to what you're expecting. |
|
Awesome, that looks great! Thank you so much! |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generator creates the same validation code for a static array of structs than for a pointer to a struct (used for dynamically allocated arrays): it first checks if the member is not null.
Given that static array addresses are always not null, GCC (12.2.1) and CLANG (16.0.1) emit pointer-bool-conversion warnings.