MinGW build fix #362
Merged
MinGW build fix #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Dec 7, 2022
|
The one thing I'm not sure about, is that I am pretty sure that LLVM/Clang on Windows can make PDB's. I was hoping CMake would have a variable or property that says "this toolchain makes pdb" but I haven't found one. This is an improvement but I wonder if we can flip the condition, only exclude for mingw? |
|
Hmm. Okay, then |
|
Changed the condition. |
rpavlik
approved these changes
Dec 16, 2022
|
Thanks very much! |
|
We received #387 to correct the exported symbols, which effectively undoes this. Can you work with that submitter to figure out the correct answer here that will work for both of you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.defand.pdbare MSVC-specific resources. MinGW can correctly build the OpenXR loader, but only with these changes.