Include a debug OutputDebugString logger for Win32 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpavlik
approved these changes
Aug 31, 2019
| @@ -28,9 +28,52 @@ | |||
| #include <string> | |||
| #include <vector> | |||
| #include <iostream> | |||
| #include <sstream> | |||
|
|
|||
| #ifdef _WIN32 | |||
There was a problem hiding this comment.
I can't keep track of which ifdef's we're using - this looks reasonable enough to me but I have no idea if it matches the other code offhand.
rpavlik
added a commit
that referenced
this pull request
Oct 8, 2019
Patch release for the 1.0 series. Note that this release includes changes to adjust the symbol exports from dynamic library versions of the loader to align with the specification. Only **core** symbols are currently exported. All extension symbols must be retrieved using `xrGetInstanceProcAddr`. ### GitHub Pull Requests These had been integrated into the public repo incrementally. - General, Build, Other - #139 - Write output atomically at the end of generator scripts - #119 - Loader test updates. - #116 - Static analysis cleanups. - Loader - #140 - Permit broader valid usage re: layers - #133 - Remove shwapi dependency - #132 - Fix directory searching for layers - #130 - Fix exporting of symbols on Windows. - #129 - Remove debug ext only when added by loader - fixes usage of debug ext on runtimes that do not provide it themselves. - #125 - Include a `OutputDebugString` logger for Win32 - Layers - #138 - Don't validate output enum buffer values - #137 - Fix incorrect filenames in the generated API layer JSON ### Internal issues - General, Build, Other - Fix warnings in MSVC static code analysis mode (internal MR 1574) - Validation layer improvements and fixes (internal MR 1568) - Update vendored jsoncpp to 1.9.1 (internal MR 1523) - Loader - Add ability to quiet the loader's default output (internal MR 1576) - Fix conformance of loader in `xrEnumerateApiLayerProperties`/`xrEnumerateInstanceExtensionProperties` - hello_xr - Simplify action usage in hello_xr (internal MR 1553) - Registry - Add `XR_EXT_view_configuration_depth_range` extension (internal MR 1502, internal issue 1201) - Reserve a Monado extension (internal MR 1541)
rhabacker
pushed a commit
to rhabacker/OpenXR-SDK-Source
that referenced
this pull request
Nov 16, 2022
Patch release for the 1.0 series. Note that this release includes changes to adjust the symbol exports from dynamic library versions of the loader to align with the specification. Only **core** symbols are currently exported. All extension symbols must be retrieved using `xrGetInstanceProcAddr`. ### GitHub Pull Requests These had been integrated into the public repo incrementally. - General, Build, Other - KhronosGroup#139 - Write output atomically at the end of generator scripts - KhronosGroup#119 - Loader test updates. - KhronosGroup#116 - Static analysis cleanups. - Loader - KhronosGroup#140 - Permit broader valid usage re: layers - KhronosGroup#133 - Remove shwapi dependency - KhronosGroup#132 - Fix directory searching for layers - KhronosGroup#130 - Fix exporting of symbols on Windows. - KhronosGroup#129 - Remove debug ext only when added by loader - fixes usage of debug ext on runtimes that do not provide it themselves. - KhronosGroup#125 - Include a `OutputDebugString` logger for Win32 - Layers - KhronosGroup#138 - Don't validate output enum buffer values - KhronosGroup#137 - Fix incorrect filenames in the generated API layer JSON ### Internal issues - General, Build, Other - Fix warnings in MSVC static code analysis mode (internal MR 1574) - Validation layer improvements and fixes (internal MR 1568) - Update vendored jsoncpp to 1.9.1 (internal MR 1523) - Loader - Add ability to quiet the loader's default output (internal MR 1576) - Fix conformance of loader in `xrEnumerateApiLayerProperties`/`xrEnumerateInstanceExtensionProperties` - hello_xr - Simplify action usage in hello_xr (internal MR 1553) - Registry - Add `XR_EXT_view_configuration_depth_range` extension (internal MR 1502, internal issue 1201) - Reserve a Monado extension (internal MR 1541)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loader automatically enables a stderr logger, but this isn't visible in non-Console win32 apps (WinMain). This adds a default debugger output for _WIN32 (OutputDebugString) which should be more useful.