Handle surface loss. #557
Merged
Handle surface loss. #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, the `CAMetalLayer` backing a view can be replaced--for example, when the window is moved to another screen, or the style bits on the window are changed. In that case, we must allow the client the opportunity to recreate the surface and swapchain. Layer-backed views always set themselves as the layer's delegate; we use this fact to Key-Value Observe the view's `layer` property. Other alternatives considered: * Registering for `NSViewGlobalFrameDidChange` notifications. Aside from only working on macOS, this doesn't actually catch every case where we want to report a lost surface. I'm not even sure it works at all for Metal. * Holding a reference to the view, and checking when its layer property has changed. * Holding a weak reference to the layer; that way, the reference will become `nil` when the layer is replaced. But this requires ARC.
billhollings
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, the
CAMetalLayerbacking a view can be replaced--forexample, when the window is moved to another screen, or the style bits
on the window are changed. In that case, we must allow the client the
opportunity to recreate the surface and swapchain.
Layer-backed views always set themselves as the layer's delegate; we use
this fact to Key-Value Observe the view's
layerproperty.Other alternatives considered:
NSViewGlobalFrameDidChangenotifications. Aside fromonly working on macOS, this doesn't actually catch every case where we
want to report a lost surface. I'm not even sure it works at all for
Metal.
has changed.
become
nilwhen the layer is replaced. But this requires ARC.