This refactors the Vulkan dockerfiles into a new base image #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asciidoctor-spec.dockerfile, containing the entire toolchain with the exception of the old Roswell implementation of the chunker. The tag is changed since this will be useful for other Khronos spec repositories with similar needs, like glTF. It also supports a different naming convention, <tag>.dockerfile, as well as Dockerfile.tag, since I was tired of tedious tab completion :-)
|
@rpavlik BTW CI is failing due to, I think, the naming change for Dockerfiles which you introduced a few weeks ago. |
|
Going ahead and merging, I have several repos to bring up to speed with the new image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asciidoctor-spec.dockerfile, containing the entire toolchain with the
exception of the old Roswell implementation of the chunker. The tag is
changed since this will be useful for other Khronos spec repositories
with similar needs, like glTF.
It also supports a different naming convention, .dockerfile, as
well as Dockerfile.tag, as I was tired of tedious tab completion :-)
@rpavlik this shouldn't affect you at all but if you get a chance, take a look at it - I'll merge in a few days otherwise.