Skip to content

Commit

Permalink
Remove .latest suffix from tag names
Browse files Browse the repository at this point in the history
This suffix is pretty nonstandard, and looks ugly.  Typically `latest`
is used as the sole value of a tag given that the "type" of an image is
already covered in the "repo" part of the name (i.e.
`KhronosGroup/$DOCKERFILE:latest`).  `.$VERSION` remains as that is what
is already actively used.

Over time we can hopefully switch to the
`KhronosGroup/$DOCKERFILE:latest` + `KhronosGroup/$DOCKERFILE:$VERSION`
format across all images.
  • Loading branch information
MarijnS95 committed Jul 1, 2022
1 parent e87a669 commit 8dc027b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .azure-pipelines/build-template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ steps:
command: ${{ parameters.command }}
arguments: "--build-arg \"VERSION=${{ parameters.version }}\""
tags: |
${{ parameters.tag }}.latest
${{ parameters.tag }}
${{ parameters.tag }}.${{ parameters.version }}
Dockerfile: ${{ parameters.tag }}.Dockerfile
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,8 @@ repository https://hub.docker.com/r/khronosgroup/docker-images.
## Structure

Each Dockerfile is named `<tag>.Dockerfile` where `<tag>` (e.g. `openxr`, `asciidoctor-spec`)
matches the tag for that image in the Dockerhub repository, suffixed with both `-latest` for the
latest revision of this image, and `-<date>` representing a timestamp when this image was last
modified.
matches the tag for that image in the Dockerhub repository (e.g. `KhronosGroup/docker-images:rust`).
A second tag is suffixed with `.<date>` representing a timestamp when this image was last modified.

## Scripts

Expand Down
4 changes: 2 additions & 2 deletions build-one.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ REPO="khronosgroup/docker-images"
fi
docker build "$@" . -f "$DOCKERFILE.Dockerfile" \
--build-arg "VERSION=$VERSION" \
-t "$REPO:$DOCKERFILE.latest" \
-t "$REPO:$DOCKERFILE" \
-t "$REPO:$DOCKERFILE.$VERSION"
if [ "$OP" == "push" ]; then
docker push "$REPO:$DOCKERFILE.latest"
docker push "$REPO:$DOCKERFILE"
docker push "$REPO:$DOCKERFILE.$VERSION"
fi
)

0 comments on commit 8dc027b

Please sign in to comment.