Codebase refactor and deployment improvements #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfaldanam
approved these changes
May 16, 2024
| default=default_, # Set a default value to mark them as not required | ||
| description=v.description, | ||
| pattern=v.regex, | ||
| default=(... if param.required else param.default), |
There was a problem hiding this comment.
How does this work against PydanticUndefined? Is the elipsis equivalent? I have not been able to find documentation on this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces significant changes aimed at improving the codebase's maintainability and testing.
Below are some notable changes:
pyproject.tomlfile. This change was necessary to ensure compatibility with the latest Python features.With these refactors, we're now in a much better position to implement unit tests.