Fix/windows

.gitignore

@@ -46,4 +46,7 @@ dmypy.json
 
 # Log history
 *.log
-*.log.*
+*.log.*
+
+# Storage volumes
+volumes/

drama/process.py

@@ -1,5 +1,7 @@
 import json
+import os
 import tempfile
+
 from abc import abstractmethod
 from datetime import datetime
 from enum import Enum
@@ -62,7 +64,11 @@ def __init__(
 
         # logging
         self.logger = get_logger(__name__)
-        self.logging_file = tempfile.NamedTemporaryFile(dir=storage.temp_dir)
+        # Note that opening a NamedTemporaryFile multiple times will cause a
+        # PermissionError on Windows. To avoid this, one solution is to set the
+        # delete flag to False. This, however, requires to delete the file manually
+        # when it is closed. Base on: https://stackoverflow.com/questions/23212435.
+        self.logging_file = tempfile.NamedTemporaryFile(dir=storage.temp_dir, delete=False)
 
     @abstractmethod
     def to_downstream(self, data: DataType) -> Message:
@@ -302,8 +308,11 @@ def close(self, force_interruption: bool = False, remove_local_dir: bool = False
         # send log to remote storage
         logging_remote = self.storage.put_file(self.logging_file.name, rename=logging_filename)
 
-        # once uploaded, delete named temporal file in local temp dir
+        # once uploaded, delete named temporal file in local temp dir.
         self.logging_file.close()
+        # Delete the temporary file explicitly since it was opened with the
+        # delete flag set to False.
+        os.unlink(self.logging_file.name)
 
         if remove_local_dir:
             # remove local directory without deleting the logging file (always kept for debugging purposes)

drama/storage/backend/local.py

@@ -1,3 +1,4 @@
+import os
 import shutil
 from pathlib import Path
 from typing import List, Optional, Union
@@ -27,7 +28,11 @@ def put_file(self, file_path: Union[str, Path], rename: Optional[str] = None) ->
         return LocalResource(resource=str(file_path))
 
     def get_file(self, data_file: str) -> str:
-        if not Path(data_file).is_file():
+        # Use os.path.isfile(data_file) instead of Path(data_file).is_file()
+        # if the data_file may contain a URL. On WIndows systems, the latter
+        # will raise a OSError: [WinError 123]. As an alternative, catch the
+        # OSError and raise a FileNotFoundError.
+        if not os.path.isfile(data_file):
             raise FileNotFoundError()
         return data_file
 

drama/storage/backend/minio.py

@@ -80,7 +80,7 @@ def put_file(self, file_path: Union[str, Path], rename: Optional[str] = None) ->
 
     def get_file(self, data_file: str) -> str:
         if not data_file.startswith("minio://"):
-            raise NotValidScheme("Object file prefix is invalid: expected `minio://`")
+            raise NotValidScheme(f"Object file prefix for '{data_file}' is invalid: expected `minio://`")
 
         # remove scheme and deconstruct path
         bucket_name, object_name = data_file[len("minio://") :].split("/", 1)