Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated progressscreen #7

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

updated progressscreen #7

wants to merge 10 commits into from

Conversation

Abhiriat
Copy link
Collaborator

@Abhiriat Abhiriat commented Oct 9, 2024

No description provided.

App/screen/Progress-screen.js Show resolved Hide resolved
package.json Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the whole file and get the content from the dev branch

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not resolved

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get this also from dev branch

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not resolved

App/screen/Progress-screen.js Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Get data from props
  • Font size
  • Line height
  • The padding of the content container is not right
  • color for the skreak label is not proper
  • gradient of a button is not proper
  • The drop shadow for the continue button is missing

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get the code from dev branch

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stll not resolved

</ImageBackground>
<Text style={[styles.streakLabel,isFontLoaded && { fontFamily: 'BalooPaaji2-Regular' }]}>Here’s your streak chart so far: ⚡</Text>
<View style={styles.streakChart}>
{(streaks || []).map((streak, index) => (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the logic for steaks is not proper how we will pass how many blocks to made

paddingRight: 15,
borderRadius: 5
},

backgroundImage: {
flex: 1,
resizeMode: 'cover',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add width 100%

<Text style={styles.backLink}>See all paths</Text>
</TouchableOpacity>
</View>
<View style={styles.contentContainer}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

increase the given padding around 35 to 50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants