Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing PyHIP with new official python wrapper of ROCm HIP #285

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clean: small fixes and clean up
  • Loading branch information
MiloLurati committed Dec 20, 2024
commit 929fe637f25c52e68250a34bd3ee56b25f479dd2
2 changes: 1 addition & 1 deletion kernel_tuner/backends/compiler.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
cp = None

try:
from jip import hip
from hip import hip
except ImportError:
hip = None

Expand Down
4 changes: 3 additions & 1 deletion kernel_tuner/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,12 +174,14 @@ def check_argument_list(kernel_name, kernel_string, args):

if correct and check_argument_type(str_dtype, kernel_argument):
continue

collected_errors[arguments_set].append(
f"Argument at position {i} of dtype: {str_dtype} does not match {kernel_argument}."
)

if not collected_errors[arguments_set]:
# We assume that if there is a possible list of arguments that matches with the provided one
# it is the right one
return

for errors in collected_errors:
Expand Down
Loading