Skip to content

Commit

Permalink
spi: dt-bindings: Move 'rx-sample-delay-ns' to spi-peripheral-props.yaml
Browse files Browse the repository at this point in the history
SPI bus per device properties must be defined in spi-peripheral-props.yaml
for unevaluatedProperties checks to work correctly on device nodes.

This has the side effect of promoting 'rx-sample-delay-ns' to be a
common property, but functionally it's no different if it was defined in
a Synopsys specific schema file.

Signed-off-by: Rob Herring <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
  • Loading branch information
robherring authored and broonie committed Jun 6, 2022
1 parent 1f19a2d commit b658be5
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 9 deletions.
18 changes: 9 additions & 9 deletions Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,16 @@ properties:

rx-sample-delay-ns:
default: 0
description: Default value of the rx-sample-delay-ns property.
description: |
Default value of the rx-sample-delay-ns property.
This value will be used if the property is not explicitly defined
for a SPI slave device. See below.
for a SPI slave device.
SPI Rx sample delay offset, unit is nanoseconds.
The delay from the default sample time before the actual sample of the
rxd input signal occurs. The "rx_sample_delay" is an optional feature
of the designware controller, and the upper limit is also subject to
controller configuration.
patternProperties:
"^.*@[0-9a-f]+$":
Expand All @@ -142,13 +149,6 @@ patternProperties:
spi-tx-bus-width:
const: 1

rx-sample-delay-ns:
description: SPI Rx sample delay offset, unit is nanoseconds.
The delay from the default sample time before the actual
sample of the rxd input signal occurs. The "rx_sample_delay"
is an optional feature of the designware controller, and the
upper limit is also subject to controller configuration.

unevaluatedProperties: false

required:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,11 @@ properties:
description:
Delay, in microseconds, after a read transfer.

rx-sample-delay-ns:
description: SPI Rx sample delay offset, unit is nanoseconds.
The delay from the default sample time before the actual
sample of the rxd input signal occurs.

spi-tx-bus-width:
description:
Bus width to the SPI bus used for write transfers.
Expand Down

0 comments on commit b658be5

Please sign in to comment.