Skip to content

Commit

Permalink
kconfig: remove unneeded symbol_empty variable
Browse files Browse the repository at this point in the history
This is used only for initializing other variables.

Use the empty string "" directly.

Please note newval.tri is unused for S_INT/HEX/STRING.

Signed-off-by: Masahiro Yamada <[email protected]>
  • Loading branch information
masahir0y committed Dec 3, 2023
1 parent 0df8e97 commit 4e244c1
Showing 1 changed file with 2 additions and 9 deletions.
11 changes: 2 additions & 9 deletions scripts/kconfig/symbol.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,6 @@ struct symbol symbol_no = {
.flags = SYMBOL_CONST|SYMBOL_VALID,
};

static struct symbol symbol_empty = {
.name = "",
.curr = { "", no },
.flags = SYMBOL_VALID,
};

struct symbol *modules_sym;
static tristate modules_val;

Expand Down Expand Up @@ -346,7 +340,7 @@ void sym_calc_value(struct symbol *sym)
case S_INT:
case S_HEX:
case S_STRING:
newval = symbol_empty.curr;
newval.val = "";
break;
case S_BOOLEAN:
case S_TRISTATE:
Expand Down Expand Up @@ -697,13 +691,12 @@ const char *sym_get_string_default(struct symbol *sym)
{
struct property *prop;
struct symbol *ds;
const char *str;
const char *str = "";
tristate val;

sym_calc_visibility(sym);
sym_calc_value(modules_sym);
val = symbol_no.curr.tri;
str = symbol_empty.curr.val;

/* If symbol has a default value look it up */
prop = sym_get_default_prop(sym);
Expand Down

0 comments on commit 4e244c1

Please sign in to comment.