Fix mempool fee ante handler when feemarket is disabled (NoBaseFee == true) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in addition, adjust the minimum gas price to greater than the smallest atomic unit of evmDenom so that we can generate transactions using NewTx with a lower limit for testing.
we are creating transactions with gas greater than the minimum
fee market is disabled
galxy25
approved these changes
May 3, 2022
drklee3
pushed a commit
that referenced
this pull request
Feb 27, 2023
… true) (#6) * fix setup test to disable base fee when enableFeeMarket is set to false; in addition, adjust the minimum gas price to greater than the smallest atomic unit of evmDenom so that we can generate transactions using NewTx with a lower limit for testing. * refactor NewTx usage in ante test w/ fee market disabled to ensure we are creating transactions with gas greater than the minimum * fix - enable mempool fee check against minimum-gas-price when fee market is disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.