Nd unify legacy evm subspace usage #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prevent panics when using the feemarket keeper with a vanilla subspace
addition to ensuring that the migration stays compatible when a subpsace is shared between the module (and thus the migration) and the keeper which is a common setup in app.go
value is not fetched and converted into new params structure
converting them to new params; this fixes key table incompatibility with the migration and a bug where the merge split block renamed value is not set from the historical state
keeper to simplify logic; avoid additional registration of types on proto codec; remove unused v2 migration code; and avoid copying of EIP712 data in parameters during conversion by using the same concrete type
and it is not passed as an argument anymore
…keys and amino codec through keeper to migrator. Both keeper and migrator are tested to ensure proper key table registraion that does not conflict and to ensure historical params are fetchable
drklee3
approved these changes
May 3, 2023
DracoLi
pushed a commit
that referenced
this pull request
Jun 18, 2023
* enable registration of feemarket legacy param key table registration to prevent panics when using the feemarket keeper with a vanilla subspace * touch up some comments for clarity, remove unused line * add some tests that enforce keeper registration of the key table in addition to ensuring that the migration stays compatible when a subpsace is shared between the module (and thus the migration) and the keeper which is a common setup in app.go * add test for current bug in legacy merge fork block fetching where value is not fetched and converted into new params structure * get tests passing by using true legacy parameters in keeper and converting them to new params; this fixes key table incompatibility with the migration and a bug where the merge split block renamed value is not set from the historical state * refactor legacy param handling in migration (non-state breaking) and in keeper to simplify logic; avoid additional registration of types on proto codec; remove unused v2 migration code; and avoid copying of EIP712 data in parameters during conversion by using the same concrete type * remove dead code * add test to ensure nil params do not panic for legacy historical queries * fix test error from rebasing onto migration paramstore refactor * remove oboselete test now that store migrations use an indepent subpsace and it is not passed as an argument anymore * refactor to use a shared legacy param store to avoid injecting param keys and amino codec through keeper to migrator. Both keeper and migrator are tested to ensure proper key table registraion that does not conflict and to ensure historical params are fetchable * add additional test to ensure store registors it's own key table when needed * remove unused private member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.