Fixes bug were migration targeted legacy parameters at the wrong store key prefix #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
key location; should have been using the params module store keys when creating a subspace;
drklee3
approved these changes
May 2, 2023
Comment on lines
24
to
30
| paramstore := paramtypes.NewSubspace( | ||
| cdc, | ||
| legacyAmino, | ||
| storeKey, | ||
| transientKey, | ||
| paramStoreKey, | ||
| paramStoreTKey, | ||
| types.ModuleName, | ||
| ).WithKeyTable(v2types.ParamKeyTable()) |
There was a problem hiding this comment.
Double checked the key usage, seems correct:
NewSubspaceis always called with the paramskeeper's storekey and transient key- Only module name is different for
NewSubspacewith each module specific subspace - Module storeKey is only used for non-params store.
DracoLi
approved these changes
May 2, 2023
DracoLi
pushed a commit
that referenced
this pull request
Jun 18, 2023
#21) key location; should have been using the params module store keys when creating a subspace;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.