-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "cancel_timeout" parameter #21
Add "cancel_timeout" parameter #21
Conversation
af4c337
to
ff4d481
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small cleanup suggestions. Otherwise pretty straight forward change. LGTM!
…ros-3295-cancel-timeout # Conflicts: # task_manager/task_manager/task_client.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Nice to have this value parameterized. Couple of the tests seem to be failing after the new changes.
Took me a while to come back to this, but fixed the tests now! |
Sorry, didn't have time to recheck the changes until now. Looks good! |
We have faced the need for variable timeout values when waiting for a task to cancel.
For example: if you have a record video task that compresses a video and saves when you press cancel. It can take several seconds to do that, and, with the current implementation, the wait for cancel will timeout and the task will succeed; although the cancelling keeps going on and the task result will eventually be sent.
Changes: