chore: fix sonar and build issues

KaotoIO · Feb 4, 2025 · a23565e · a23565e
1 parent e7c6db0
commit a23565e
Show file tree

Hide file tree

Showing 3 changed files with 135 additions and 137 deletions.
diff --git a/packages/ui/src/components/Icons/create-icon.tsx b/packages/ui/src/components/Icons/create-icon.tsx
@@ -31,7 +31,7 @@ export function createIcon({
   svgPath,
 }: IconDefinition): ComponentClass<SVGIconProps> {
   return class SVGIcon extends Component<SVGIconProps> {
-    static displayName = name;
+    static readonly displayName = name;
 
     id = `icon-title-${currentId++}`;
 
@@ -47,10 +47,9 @@ export function createIcon({
           className={classes}
           viewBox={viewBox}
           fill="currentColor"
-          aria-labelledby={hasTitle ? this.id : null}
-          aria-hidden={hasTitle ? null : true}
+          aria-labelledby={hasTitle ? this.id : undefined}
+          aria-hidden={hasTitle ? undefined : true}
           transform={transform}
-          role="img"
           width="1em"
           height="1em"
           {...(props as Omit<SVGProps<SVGElement>, 'ref'>)} // Lie.

diff --git a/packages/ui/src/components/Visualization/Canvas/Canvas.tsx b/packages/ui/src/components/Visualization/Canvas/Canvas.tsx
@@ -1,4 +1,3 @@
-import { Icon } from '@patternfly/react-core';
 import { CatalogIcon } from '@patternfly/react-icons';
 import {
   Model,