Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cargo clippy && fmt #302

Merged
merged 1 commit into from
Oct 2, 2021
Merged

Conversation

zhiburt
Copy link
Contributor

@zhiburt zhiburt commented Oct 1, 2021

For some reason cargo fmt changes showed like they changed entire file where's in reality is 2 lines....
It showed better in vscode diff.

@Kampfkarren
Copy link
Owner

Kampfkarren commented Oct 2, 2021

For some reason cargo fmt changes showed like they changed entire file where's in reality is 2 lines....

It's the newlines, can you try to preserve them if possible? Actually no, you're good, it's converting them to LF.

@@ -46,6 +46,7 @@ macro_rules! make_node_visitor {
)+
}

#[allow(clippy::enum_variant_names)]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this for?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, because they're camel case...I wonder why I did that.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see! Fair enough.

image

@Kampfkarren Kampfkarren merged commit 917e7aa into Kampfkarren:main Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants