Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude not working with absolute path in some cases #593

Open
chriscerie opened this issue Mar 23, 2024 · 1 comment · May be fixed by #618
Open

Exclude not working with absolute path in some cases #593

chriscerie opened this issue Mar 23, 2024 · 1 comment · May be fixed by #618
Labels
A-bin Area: selene, the program C-bug Category: Bug

Comments

@chriscerie
Copy link
Collaborator

These are all executed from the selene-test workspace.

Works:

exclude = ["**/file.lua"]

selene C:\Users\chris\OneDrive\Documents\selene-test\src\file.lua

Works:

exclude = ["src/**"]

selene src/file.lua

Doesn't work:

exclude = ["src/**"]

selene C:\Users\chris\OneDrive\Documents\selene-test\src\file.lua
@chriscerie chriscerie added C-bug Category: Bug A-bin Area: selene, the program labels Mar 23, 2024
dqkqd added a commit to dqkqd/selene that referenced this issue Oct 12, 2024
@dqkqd
Exclude files in absolute path if they match exclude pattern (Kampfka…
25bbca1 
…rren#593)
@dqkqd dqkqd linked a pull request Oct 12, 2024 that will close this issue
Open
dqkqd added a commit to dqkqd/selene that referenced this issue Oct 12, 2024
@dqkqd
Exclude files in absolute path if they match exclude pattern (Kampfka…
86c0026 
…rren#593)
@dqkqd
Copy link

dqkqd commented Oct 12, 2024

@chriscerie

Hi, I have created a PR for this issue. Please have a look.

dqkqd added a commit to dqkqd/selene that referenced this issue Oct 13, 2024
@dqkqd @github-actions
Exclude files in absolute path if they match exclude pattern (Kampfka…
003b3b5 
…rren#593)
dqkqd added a commit to dqkqd/selene that referenced this issue Oct 13, 2024
@dqkqd @github-actions
Exclude files in absolute path if they match exclude pattern (Kampfka…
5a5a878 
…rren#593)
dqkqd added a commit to dqkqd/selene that referenced this issue Oct 13, 2024
@dqkqd @github-actions
Exclude files in absolute path if they match exclude pattern (Kampfka…
4293812 
…rren#593)
dqkqd added a commit to dqkqd/selene that referenced this issue Oct 13, 2024
@dqkqd
Exclude files in absolute path if they match exclude pattern (Kampfka…
f606559 
…rren#593)
@chriscerie chriscerie marked this as a duplicate of #627 Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-bin Area: selene, the program C-bug Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Exclude not working with absolute path in some cases (#593) dqkqd/selene
2 participants
@dqkqd @chriscerie