Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote duplicate_keys from warning to error #262

Closed
Kampfkarren opened this issue Jun 20, 2021 · 0 comments · Fixed by #301
Closed

Promote duplicate_keys from warning to error #262

Kampfkarren opened this issue Jun 20, 2021 · 0 comments · Fixed by #301
Labels
A-lints Area: Relating to a lint directly E-easy Call for participation: Experience needed to fix: Easy / not much good first issue Good for newcomers

Comments

@Kampfkarren
Copy link
Owner

Correctness lints should be errors, since there's never a case where they are valid.
@Kampfkarren Kampfkarren added good first issue Good for newcomers A-lints Area: Relating to a lint directly E-easy Call for participation: Experience needed to fix: Easy / not much labels Jun 20, 2021
@zhiburt zhiburt mentioned this issue Oct 1, 2021
Merged
Kampfkarren pushed a commit that referenced this issue Oct 3, 2021
@zhiburt
Make dublicate_key lint severity Error #(#262) (#301)
500e0cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lints Area: Relating to a lint directly E-easy Call for participation: Experience needed to fix: Easy / not much good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make dublicate_key lint severity Error #(#262) zhiburt/selene
1 participant
@Kampfkarren