feat: add end-key to pool

docs/static/openapi.yml

@@ -669,6 +669,7 @@ paths:
                                       - POOL_STATUS_NOT_ENOUGH_DELEGATION
                                       - POOL_STATUS_UPGRADING
                                       - POOL_STATUS_VOTING_POWER_TOO_HIGH
+                                      - POOL_STATUS_END_KEY_REACHED
                                     default: POOL_STATUS_UNSPECIFIED
                               points:
                                 type: string
@@ -1067,6 +1068,7 @@ paths:
                             - POOL_STATUS_NOT_ENOUGH_DELEGATION
                             - POOL_STATUS_UPGRADING
                             - POOL_STATUS_VOTING_POWER_TOO_HIGH
+                            - POOL_STATUS_END_KEY_REACHED
                           default: POOL_STATUS_UNSPECIFIED
                       title: >-
                         BasicPool contains the necessary properties need for a
@@ -3912,6 +3914,7 @@ paths:
                                       - POOL_STATUS_NOT_ENOUGH_DELEGATION
                                       - POOL_STATUS_UPGRADING
                                       - POOL_STATUS_VOTING_POWER_TOO_HIGH
+                                      - POOL_STATUS_END_KEY_REACHED
                                     default: POOL_STATUS_UNSPECIFIED
                               points:
                                 type: string
@@ -4905,6 +4908,9 @@ paths:
                         type: integer
                         format: int64
                         description: compression_id ...
+                      end_key:
+                        type: string
+                        description: end_key ...
                   bundle_proposal:
                     description: bundle_proposal ...
                     type: object
@@ -5022,6 +5028,7 @@ paths:
                       - POOL_STATUS_NOT_ENOUGH_DELEGATION
                       - POOL_STATUS_UPGRADING
                       - POOL_STATUS_VOTING_POWER_TOO_HIGH
+                      - POOL_STATUS_END_KEY_REACHED
                     default: POOL_STATUS_UNSPECIFIED
                   account:
                     type: string
@@ -5438,6 +5445,9 @@ paths:
                           type: integer
                           format: int64
                           description: compression_id ...
+                        end_key:
+                          type: string
+                          description: end_key ...
                     bundle_proposal:
                       description: bundle_proposal ...
                       type: object
@@ -5555,6 +5565,7 @@ paths:
                         - POOL_STATUS_NOT_ENOUGH_DELEGATION
                         - POOL_STATUS_UPGRADING
                         - POOL_STATUS_VOTING_POWER_TOO_HIGH
+                        - POOL_STATUS_END_KEY_REACHED
                       default: POOL_STATUS_UNSPECIFIED
                     account:
                       type: string
@@ -6073,6 +6084,7 @@ paths:
                                 - POOL_STATUS_NOT_ENOUGH_DELEGATION
                                 - POOL_STATUS_UPGRADING
                                 - POOL_STATUS_VOTING_POWER_TOO_HIGH
+                                - POOL_STATUS_END_KEY_REACHED
                               default: POOL_STATUS_UNSPECIFIED
                         points:
                           type: string
@@ -6500,6 +6512,7 @@ paths:
                                   - POOL_STATUS_NOT_ENOUGH_DELEGATION
                                   - POOL_STATUS_UPGRADING
                                   - POOL_STATUS_VOTING_POWER_TOO_HIGH
+                                  - POOL_STATUS_END_KEY_REACHED
                                 default: POOL_STATUS_UNSPECIFIED
                           points:
                             type: string
@@ -7040,6 +7053,7 @@ paths:
                                       - POOL_STATUS_NOT_ENOUGH_DELEGATION
                                       - POOL_STATUS_UPGRADING
                                       - POOL_STATUS_VOTING_POWER_TOO_HIGH
+                                      - POOL_STATUS_END_KEY_REACHED
                                     default: POOL_STATUS_UNSPECIFIED
                               points:
                                 type: string
@@ -7509,6 +7523,7 @@ paths:
                                   - POOL_STATUS_NOT_ENOUGH_DELEGATION
                                   - POOL_STATUS_UPGRADING
                                   - POOL_STATUS_VOTING_POWER_TOO_HIGH
+                                  - POOL_STATUS_END_KEY_REACHED
                                 default: POOL_STATUS_UNSPECIFIED
                           points:
                             type: string

proto/kyve/pool/v1beta1/pool.proto

@@ -32,6 +32,9 @@ enum PoolStatus {
   // POOL_STATUS_VOTING_POWER_TOO_HIGH indicates, that one validator
   // has more than 50% voting power and that the pool is halted
   POOL_STATUS_VOTING_POWER_TOO_HIGH = 6;
+  // POOL_STATUS_END_KEY_REACHED indicates, that the end key has been
+  // reached and that the pool is halted
+  POOL_STATUS_END_KEY_REACHED = 7;
 }
 
 // Protocol holds all info about the current pool version and the
@@ -109,4 +112,7 @@ message Pool {
   uint32 current_storage_provider_id = 18;
   // compression_id ...
   uint32 current_compression_id = 19;
+
+  // end_key ...
+  string end_key = 20;
 }

x/bundles/keeper/logic_bundles.go

@@ -30,6 +30,11 @@ func (k Keeper) AssertPoolCanRun(ctx sdk.Context, poolId uint64) error {
 		return types.ErrPoolDisabled
 	}
 
+	// Error if the end key is reached
+	if pool.EndKey != "" && pool.CurrentKey == pool.EndKey {
+		return types.ErrEndKeyReached
+	}
+
 	// Get the total and the highest delegation of a single validator in the pool
 	totalDelegation, highestDelegation := k.delegationKeeper.GetTotalAndHighestDelegationOfPool(ctx, poolId)
 

x/bundles/keeper/logic_bundles_test.go

@@ -20,6 +20,7 @@ TEST CASES - logic_bundles.go
 * Assert pool can run while min delegation is not reached
 * Assert pool can run
 * Assert pool can run while pool has no funds
+* Assert pool can run when endKey is reached
 
 * Assert can vote if sender is no staker
 * Assert can vote if bundle is dropped
@@ -84,7 +85,7 @@ var _ = Describe("logic_bundles.go", Ordered, func() {
 	// ASSERT POOL CAN RUN
 
 	It("Assert pool can run while pool is upgrading", func() {
-		// ASSERT
+		// ARRANGE
 		pool, _ := s.App().PoolKeeper.GetPool(s.Ctx(), 0)
 		pool.UpgradePlan = &pooltypes.UpgradePlan{
 			Version:     "1.0.0",
@@ -126,7 +127,7 @@ var _ = Describe("logic_bundles.go", Ordered, func() {
 	})
 
 	It("Assert pool can run while pool is disabled", func() {
-		// ASSERT
+		// ARRANGE
 		s.RunTxStakersSuccess(&stakertypes.MsgCreateStaker{
 			Creator: i.STAKER_0,
 			Amount:  100 * i.KYVE,
@@ -164,7 +165,7 @@ var _ = Describe("logic_bundles.go", Ordered, func() {
 	})
 
 	It("Assert pool can run while min delegation is not reached", func() {
-		// ASSERT
+		// ARRANGE
 		s.RunTxStakersSuccess(&stakertypes.MsgCreateStaker{
 			Creator: i.STAKER_0,
 			Amount:  20 * i.KYVE,
@@ -197,7 +198,7 @@ var _ = Describe("logic_bundles.go", Ordered, func() {
 	})
 
 	It("Assert pool can run while voting power of one node is too high", func() {
-		// ASSERT
+		// ARRANGE
 		msg := &pooltypes.MsgCreatePool{
 			Authority:            gov,
 			Name:                 "PoolTest",
@@ -248,7 +249,7 @@ var _ = Describe("logic_bundles.go", Ordered, func() {
 	})
 
 	It("Assert pool can run", func() {
-		// ASSERT
+		// ARRANGE
 		s.RunTxStakersSuccess(&stakertypes.MsgCreateStaker{
 			Creator: i.STAKER_0,
 			Amount:  50 * i.KYVE,
@@ -281,7 +282,7 @@ var _ = Describe("logic_bundles.go", Ordered, func() {
 	})
 
 	It("Assert pool can run while pool has no funds", func() {
-		// ASSERT
+		// ARRANGE
 		msg := &pooltypes.MsgCreatePool{
 			Authority:            gov,
 			Name:                 "PoolTest",
@@ -331,10 +332,24 @@ var _ = Describe("logic_bundles.go", Ordered, func() {
 		Expect(err).NotTo(HaveOccurred())
 	})
 
+	It("Assert pool can run when endKey is reached", func() {
+		// ARRANGE
+		pool, _ := s.App().PoolKeeper.GetPool(s.Ctx(), 0)
+		pool.EndKey = "0"
+		pool.CurrentKey = "0"
+		s.App().PoolKeeper.SetPool(s.Ctx(), pool)
+
+		// ACT
+		err := s.App().BundlesKeeper.AssertPoolCanRun(s.Ctx(), 0)
+
+		// ASSERT
+		Expect(err).To(Equal(bundlesTypes.ErrEndKeyReached))
+	})
+
 	// ASSERT CAN VOTE
 
 	It("Assert can vote if sender is no staker", func() {
-		// ASSERT
+		// ARRANGE
 		s.RunTxStakersSuccess(&stakertypes.MsgCreateStaker{
 			Creator: i.STAKER_0,
 			Amount:  100 * i.KYVE,
@@ -396,7 +411,7 @@ var _ = Describe("logic_bundles.go", Ordered, func() {
 	})
 
 	It("Assert can vote if bundle is dropped", func() {
-		// ASSERT
+		// ARRANGE
 		s.RunTxStakersSuccess(&stakertypes.MsgCreateStaker{
 			Creator: i.STAKER_0,
 			Amount:  100 * i.KYVE,
@@ -455,7 +470,7 @@ var _ = Describe("logic_bundles.go", Ordered, func() {
 	})
 
 	It("Assert can vote if storage id does not match", func() {
-		// ASSERT
+		// ARRANGE
 		s.RunTxStakersSuccess(&stakertypes.MsgCreateStaker{
 			Creator: i.STAKER_0,
 			Amount:  100 * i.KYVE,
@@ -513,7 +528,7 @@ var _ = Describe("logic_bundles.go", Ordered, func() {
 	})
 
 	It("Assert can vote if sender has already voted valid", func() {
-		// ASSERT
+		// ARRANGE
 		s.RunTxStakersSuccess(&stakertypes.MsgCreateStaker{
 			Creator: i.STAKER_0,
 			Amount:  100 * i.KYVE,
@@ -580,7 +595,7 @@ var _ = Describe("logic_bundles.go", Ordered, func() {
 	})
 
 	It("Assert can vote if sender has already voted invalid", func() {
-		// ASSERT
+		// ARRANGE
 		s.RunTxStakersSuccess(&stakertypes.MsgCreateStaker{
 			Creator: i.STAKER_0,
 			Amount:  100 * i.KYVE,
@@ -647,7 +662,7 @@ var _ = Describe("logic_bundles.go", Ordered, func() {
 	})
 
 	It("Assert can vote", func() {
-		// ASSERT
+		// ARRANGE
 		s.RunTxStakersSuccess(&stakertypes.MsgCreateStaker{
 			Creator: i.STAKER_0,
 			Amount:  100 * i.KYVE,
@@ -708,7 +723,7 @@ var _ = Describe("logic_bundles.go", Ordered, func() {
 	// ASSERT CAN PROPOSE
 
 	It("Assert can propose if sender is no staker", func() {
-		// ASSERT
+		// ARRANGE
 		s.RunTxStakersSuccess(&stakertypes.MsgCreateStaker{
 			Creator: i.STAKER_0,
 			Amount:  100 * i.KYVE,
@@ -750,7 +765,7 @@ var _ = Describe("logic_bundles.go", Ordered, func() {
 	})
 
 	It("Assert can propose if sender is not next uploader", func() {
-		// ASSERT
+		// ARRANGE
 		s.RunTxStakersSuccess(&stakertypes.MsgCreateStaker{
 			Creator: i.STAKER_0,
 			Amount:  100 * i.KYVE,
@@ -792,7 +807,7 @@ var _ = Describe("logic_bundles.go", Ordered, func() {
 	})
 
 	It("Assert can propose if upload interval has not passed", func() {
-		// ASSERT
+		// ARRANGE
 		s.RunTxStakersSuccess(&stakertypes.MsgCreateStaker{
 			Creator: i.STAKER_0,
 			Amount:  100 * i.KYVE,
@@ -837,7 +852,7 @@ var _ = Describe("logic_bundles.go", Ordered, func() {
 	})
 
 	It("Assert can propose if index does not match", func() {
-		// ASSERT
+		// ARRANGE
 		s.RunTxStakersSuccess(&stakertypes.MsgCreateStaker{
 			Creator: i.STAKER_0,
 			Amount:  100 * i.KYVE,
@@ -879,7 +894,7 @@ var _ = Describe("logic_bundles.go", Ordered, func() {
 	})
 
 	It("Assert can propose", func() {
-		// ASSERT
+		// ARRANGE
 		s.RunTxStakersSuccess(&stakertypes.MsgCreateStaker{
 			Creator: i.STAKER_0,
 			Amount:  100 * i.KYVE,

x/bundles/types/errors.go

@@ -23,4 +23,5 @@ var (
 	ErrAlreadyVotedInvalid     = errors.Register(ModuleName, 1205, "already voted invalid on bundle proposal")
 	ErrAlreadyVotedAbstain     = errors.Register(ModuleName, 1206, "already voted abstain on bundle proposal")
 	ErrVotingPowerTooHigh      = errors.Register(ModuleName, 1207, "staker in pool has more than 50% voting power")
+	ErrEndKeyReached           = errors.Register(ModuleName, 1208, "end key reached")
 )

x/pool/keeper/msg_server_update_pool.go

@@ -59,6 +59,9 @@ func (k msgServer) UpdatePool(goCtx context.Context, req *types.MsgUpdatePool) (
 	if update.CompressionId != nil {
 		pool.CurrentCompressionId = *update.CompressionId
 	}
+	if update.EndKey != nil {
+		pool.EndKey = *update.EndKey
+	}
 
 	k.SetPool(ctx, pool)
 

x/pool/keeper/msg_server_update_pool_test.go

@@ -46,7 +46,7 @@ var _ = Describe("msg_server_update_pool.go", Ordered, func() {
 		msg := &types.MsgUpdatePool{
 			Authority: i.DUMMY[0],
 			Id:        0,
-			Payload:   "{\"Name\":\"TestPool\",\"Runtime\":\"@kyve/test\",\"Logo\":\"ar://Tewyv2P5VEG8EJ6AUQORdqNTectY9hlOrWPK8wwo-aU\",\"Config\":\"ar://DgdB-2hLrxjhyEEbCML__dgZN5_uS7T6Z5XDkaFh3P0\",\"StartKey\":\"0\",\"UploadInterval\":60,\"InflationShareWeight\":10000,\"MinDelegation\":\"100000000000\",\"MaxBundleSize\":100,\"Version\":\"0.0.0\",\"Binaries\":\"{}\",\"StorageProviderId\":2,\"CompressionId\":1}",
+			Payload:   "{\"Name\":\"TestPool\",\"Runtime\":\"@kyve/test\",\"Logo\":\"ar://Tewyv2P5VEG8EJ6AUQORdqNTectY9hlOrWPK8wwo-aU\",\"Config\":\"ar://DgdB-2hLrxjhyEEbCML__dgZN5_uS7T6Z5XDkaFh3P0\",\"StartKey\":\"0\",\"UploadInterval\":60,\"InflationShareWeight\":10000,\"MinDelegation\":\"100000000000\",\"MaxBundleSize\":100,\"Version\":\"0.0.0\",\"Binaries\":\"{}\",\"StorageProviderId\":2,\"CompressionId\":1,\"EndKey\":\"1\"}",
 		}
 
 		// ACT
@@ -61,7 +61,7 @@ var _ = Describe("msg_server_update_pool.go", Ordered, func() {
 		msg := &types.MsgUpdatePool{
 			Authority: i.DUMMY[0],
 			Id:        0,
-			Payload:   "{\"Name\":\"TestPool\",\"Runtime\":\"@kyve/test\",\"Logo\":\"ar://Tewyv2P5VEG8EJ6AUQORdqNTectY9hlOrWPK8wwo-aU\",\"Config\":\"ar://DgdB-2hLrxjhyEEbCML__dgZN5_uS7T6Z5XDkaFh3P0\",\"StartKey\":\"0\",\"UploadInterval\":60,\"InflationShareWeight\":10000,\"MinDelegation\":\"100000000000\",\"MaxBundleSize\":100,\"Version\":\"0.0.0\",\"Binaries\":\"{}\",\"StorageProviderId\":2,\"CompressionId\":1}",
+			Payload:   "{\"Name\":\"TestPool\",\"Runtime\":\"@kyve/test\",\"Logo\":\"ar://Tewyv2P5VEG8EJ6AUQORdqNTectY9hlOrWPK8wwo-aU\",\"Config\":\"ar://DgdB-2hLrxjhyEEbCML__dgZN5_uS7T6Z5XDkaFh3P0\",\"StartKey\":\"0\",\"UploadInterval\":60,\"InflationShareWeight\":10000,\"MinDelegation\":\"100000000000\",\"MaxBundleSize\":100,\"Version\":\"0.0.0\",\"Binaries\":\"{}\",\"StorageProviderId\":2,\"CompressionId\":1,\"EndKey\":\"1\"}",
 		}
 
 		proposal, _ := BuildGovernanceTxs(s, []sdk.Msg{msg})
@@ -78,7 +78,7 @@ var _ = Describe("msg_server_update_pool.go", Ordered, func() {
 		msg := &types.MsgUpdatePool{
 			Authority: gov,
 			Id:        0,
-			Payload:   "{\"Name\":\"TestPool\",\"Runtime\":\"@kyve/test\",\"Logo\":\"ar://Tewyv2P5VEG8EJ6AUQORdqNTectY9hlOrWPK8wwo-aU\",\"Config\":\"ar://DgdB-2hLrxjhyEEbCML__dgZN5_uS7T6Z5XDkaFh3P0\",\"StartKey\":\"0\",\"UploadInterval\":60,\"InflationShareWeight\":10000,\"MinDelegation\":100000000000,\"MaxBundleSize\":100,\"Version\":\"0.0.0\",\"Binaries\":\"{}\",\"StorageProviderId\":2,\"CompressionId\":1}",
+			Payload:   "{\"Name\":\"TestPool\",\"Runtime\":\"@kyve/test\",\"Logo\":\"ar://Tewyv2P5VEG8EJ6AUQORdqNTectY9hlOrWPK8wwo-aU\",\"Config\":\"ar://DgdB-2hLrxjhyEEbCML__dgZN5_uS7T6Z5XDkaFh3P0\",\"StartKey\":\"0\",\"UploadInterval\":60,\"InflationShareWeight\":10000,\"MinDelegation\":100000000000,\"MaxBundleSize\":100,\"Version\":\"0.0.0\",\"Binaries\":\"{}\",\"StorageProviderId\":2,\"CompressionId\":1,\"EndKey\":\"1\"}",
 		}
 
 		p, v := BuildGovernanceTxs(s, []sdk.Msg{msg})
@@ -128,6 +128,7 @@ var _ = Describe("msg_server_update_pool.go", Ordered, func() {
 			},
 			CurrentStorageProviderId: 2,
 			CurrentCompressionId:     1,
+			EndKey:                   "1",
 		}))
 	})
 
@@ -186,6 +187,7 @@ var _ = Describe("msg_server_update_pool.go", Ordered, func() {
 			},
 			CurrentStorageProviderId: 0,
 			CurrentCompressionId:     0,
+			EndKey:                   "",
 		}))
 	})
 
@@ -197,7 +199,7 @@ var _ = Describe("msg_server_update_pool.go", Ordered, func() {
 		msg := &types.MsgUpdatePool{
 			Authority: gov,
 			Id:        1,
-			Payload:   "{\"Name\":\"TestPool2\",\"Runtime\":\"@kyve/test\",\"Logo\":\"ar://Tewyv2P5VEG8EJ6AUQORdqNTectY9hlOrWPK8wwo-aU\",\"Config\":\"ar://DgdB-2hLrxjhyEEbCML__dgZN5_uS7T6Z5XDkaFh3P0\",\"StartKey\":\"0\",\"UploadInterval\":60,\"InflationShareWeight\":10000,\"MinDelegation\":100000000000,\"MaxBundleSize\":100,\"Version\":\"0.0.0\",\"Binaries\":\"{}\",\"StorageProviderId\":2,\"CompressionId\":1}",
+			Payload:   "{\"Name\":\"TestPool2\",\"Runtime\":\"@kyve/test\",\"Logo\":\"ar://Tewyv2P5VEG8EJ6AUQORdqNTectY9hlOrWPK8wwo-aU\",\"Config\":\"ar://DgdB-2hLrxjhyEEbCML__dgZN5_uS7T6Z5XDkaFh3P0\",\"StartKey\":\"0\",\"UploadInterval\":60,\"InflationShareWeight\":10000,\"MinDelegation\":100000000000,\"MaxBundleSize\":100,\"Version\":\"0.0.0\",\"Binaries\":\"{}\",\"StorageProviderId\":2,\"CompressionId\":1,\"EndKey\":\"1\"}",
 		}
 
 		p, v := BuildGovernanceTxs(s, []sdk.Msg{msg})
@@ -246,6 +248,7 @@ var _ = Describe("msg_server_update_pool.go", Ordered, func() {
 			},
 			CurrentStorageProviderId: 2,
 			CurrentCompressionId:     1,
+			EndKey:                   "1",
 		}))
 	})
 
@@ -254,7 +257,7 @@ var _ = Describe("msg_server_update_pool.go", Ordered, func() {
 		msg := &types.MsgUpdatePool{
 			Authority: gov,
 			Id:        1,
-			Payload:   "invalid_json_payload\",\"Runtime\":\"@kyve/test\",\"Logo\":\"ar://Tewyv2P5VEG8EJ6AUQORdqNTectY9hlOrWPK8wwo-aU\",\"Config\":\"ar://DgdB-2hLrxjhyEEbCML__dgZN5_uS7T6Z5XDkaFh3P0\",\"StartKey\":\"0\",\"UploadInterval\":60,\"InflationShareWeight\":10000,\"MinDelegation\":100000000000,\"MaxBundleSize\":100,\"Version\":\"0.0.0\",\"Binaries\":\"{}\",\"StorageProviderId\":2,\"CompressionId\":1}",
+			Payload:   "invalid_json_payload\",\"Runtime\":\"@kyve/test\",\"Logo\":\"ar://Tewyv2P5VEG8EJ6AUQORdqNTectY9hlOrWPK8wwo-aU\",\"Config\":\"ar://DgdB-2hLrxjhyEEbCML__dgZN5_uS7T6Z5XDkaFh3P0\",\"StartKey\":\"0\",\"UploadInterval\":60,\"InflationShareWeight\":10000,\"MinDelegation\":100000000000,\"MaxBundleSize\":100,\"Version\":\"0.0.0\",\"Binaries\":\"{}\",\"StorageProviderId\":2,\"CompressionId\":1,\"EndKey\":\"1\"}",
 		}
 
 		p, _ := BuildGovernanceTxs(s, []sdk.Msg{msg})

x/pool/types/msgs.go

@@ -69,6 +69,7 @@ type PoolUpdate struct {
 	MaxBundleSize        *uint64
 	StorageProviderId    *uint32
 	CompressionId        *uint32
+	EndKey               *string
 }
 
 // ValidateBasic does a sanity check on the provided data.