-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test_flags
input
#32
Conversation
The input sets the command-line flags provided to `makepkg` when trying to build the package (if the `test` option is enabled). The input is optional and its default value is the same as before introducing this input.
This is needed to be able to install packages with makepkg
After you resolve my requests, can you test |
Can you try |
Here is a successful run from a few minutes ago: https://github.com/fuljo/rofi-vscode-mode/actions/runs/3463753986 I used the |
v2.6.0 is released. |
I really enjoyed the
test
option to check that the package could be succesfully built withmakepkg
. The only flaw for me is that its command line flags are fixed:github-actions-deploy-aur/build.sh
Lines 82 to 87 in 325b53d
Changes
This PR adds a new input called
test_flags
which sets the command line flags formakepkg
.Its default value falls back to the old behavior, so there are no regression problems.
Furthermore, it makes the
builder
user a sudoer so it is able to install the dependencies.Example
I use it in this workflow where I need to install dependencies in order to build the package, and I also check that it installs successfully. Here is the interesting snippet:
You can see a succesful run of my fork here.