-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add makepkg option - optional basic check that PKGBUILD could be built #31
Conversation
Optional basic check that PKGBUILD could be built
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please update README.md
@KSXGitHub I've renamed makepkg to 'test' and updated readme also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging this, I want to make sure the scripts run without problems. Can you use github-actions-deploy-aur@89cbe4c6760a199744d0e3a15b296f8f53d5d278
in your CI and then let me see the result?
@KSXGitHub I use it in my workflows, here you can see yesterday workflow run. Look at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thank you.
It'll be handy to be able to check that
makepkg
passed without errors before packaging and deploying new release. E.g., file names or paths in the source archive could be changed. And with such "test build" we could catch failed pkg before releasing.This check is optional. Also,
makepkg
is launched with--nodeps
option for simplicity.