Set bot useragent for GitHub Action #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 29, 2021
HebaruSan
force-pushed
the
fix/useragent
branch
from
60542e2 to
e08caef
Compare
DasSkelett
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See KSP-CKAN/CKAN#3490; when the GitHub Action uses
netkan.exeandckan.exe, itsUser-Agentdoes not identify it as a bot, which it ought to do, see KSP-SpaceDock/SpaceDock#436.Changes
Based on the same examples used for that other pull request, the GitHub Action's
User-Agentis now:Mozilla/5.0 (compatible; Netkanbot/1.0; CKAN; +https://github.com/KSP-CKAN/xKAN-meta_testing)I think parsers will just check whether
botoccurs in the browser family.Blocking external dependencies
The
HyperEditandGraphotronmods use a combination of strange URLs:... and the
User-Agentstring to identify Netkan requests. Requesting these URLs with the wrongUser-Agentstring results in an HTTP status 403 error. Before we merge these changes, we must work with @Ezriilc to update thekerbaltek.comsite to support the newUser-Agentformats as well as the old format.