Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create KerbalChangelog.netkan #6858

Merged
merged 3 commits into from
Nov 21, 2018
Merged

Create KerbalChangelog.netkan #6858

merged 3 commits into from
Nov 21, 2018

Conversation

AmberCronin
Copy link
Contributor

If possible I'd like this mod to be available for KSP v.1.4.x AND 1.5.x. I take it that ksp_version is the max KSP version that the mod is available for, is this the case?

If possible I'd like this mod to be available for KSP v.1.4.x AND 1.5.x. I take it that `ksp_version` is the max KSP version that the mod is available for, is this the case?
@HebaruSan
Copy link
Member

No, ksp_version allows an exact match only. ksp_version_min and ksp_version_max can be used to support a range.

@HebaruSan
Copy link
Member

And a more flexible approach is to put a KSP-AVC .version file in your download, which can then be read into CKAN metadata with the $vref property.

@AmberCronin
Copy link
Contributor Author

@HebaruSan I think that should do the trick, but I'm not sure why the build is failing...

@HebaruSan
Copy link
Member

Well there was a syntax error, but I would expect it to still fail until the download contains a .version file. I don't see one in the latest ZIP.

@AmberCronin
Copy link
Contributor Author

Cool, thank you! I've updated the release on GitHub to contain the version file.

@HebaruSan
Copy link
Member

Looks good now. (The usual validation scripts aren't available due to #6856, but I ran netkan.exe locally and it looks fine.)

Thanks for the submission! Merging...

@HebaruSan HebaruSan merged commit 5e1b608 into KSP-CKAN:master Nov 21, 2018
@AmberCronin AmberCronin deleted the patch-2 branch November 21, 2018 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants