Submit YAML netkans from SpaceDock #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Enhancement
DasSkelett
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As of KSP-CKAN/CKAN#3367, netkans are allowed to use YAML format. I don't know how quickly we want to convert random mods to YAML since that would represent a dependency on YAML and we would lose the option to roll it back to JSON, but at some point it might be nice to start changing over.
Thought of while reviewing KSP-CKAN/NetKAN#8568, in which the YAML validator complained about a missing newline at the end of the file. Rather than just adding a newline, we might as well take full advantage of the YAML work.
Changes
Now if we merge this PR, newly added mods on SpaceDock with the CKAN badge will have the netkans in their pull requests submitted in YAML instead of JSON. This should make them easier to read and edit, without disrupting already indexed mods.