Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Audit Recommendations option #3988

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Conversation

HebaruSan
Copy link
Member

Problem

If you have any DLCs installed in a KSP1 instance, the Audit Recommendations option doesn't work.

Cause

As of #3892, ModuleInstaller.FindRecommendations uses RelationshipResolver to get the recommendations and suggestions for the full dependency tree of a given group of mods. (Previously it had a lot of its own duplicative logic that has been refactored to use the shared logic in RelationshipResolver.)

Audit Recommendations passes the list of installed modules, which includes DLCs, and RelationshipResolver throws ModuleIsDLCKraken when it finds a DLC in its input.

Changes

Now ModuleInstaller.FindRecommendations filters DLCs out of the sequence of modules it passes to RelationshipResolver, so the exception is no longer thrown and Audit Recommendations works again.

We could have had GUI.Main.AuditRecommendations do this instead, but it seems more appropriate to enforce the constraint at the point where RelationshipResolver enters the picture.

Fixes #3987.

@HebaruSan HebaruSan added Bug Something is not working as intended Core (ckan.dll) Issues affecting the core part of CKAN Relationships Issues affecting depends, recommends, etc. labels Dec 31, 2023
@HebaruSan HebaruSan merged commit cbfad76 into KSP-CKAN:master Dec 31, 2023
8 checks passed
@HebaruSan HebaruSan deleted the fix/audit-recs branch December 31, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended Core (ckan.dll) Issues affecting the core part of CKAN Relationships Issues affecting depends, recommends, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: "Audit recommendations" not working
1 participant