Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading of legacy registry.json files #3937

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Fix loading of legacy registry.json files #3937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Core/Converters/JsonAlwaysEmptyObjectConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,11 @@ namespace CKAN
public class JsonAlwaysEmptyObjectConverter : JsonConverter
{
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
=> Activator.CreateInstance(objectType);
{
// Read and discard this field's object (without this, loading stops!)
_ = JToken.Load(reader);
return Activator.CreateInstance(objectType);
}

public override bool CanWrite => true;
public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
Expand Down
Loading