Don't include DLC in modpacks by default #3417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Bug
DasSkelett
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
DLC have been making mischief for modpacks.
(We did not make a change to exclude DLC by default; I was thinking of #3139, which did this for modules from custom .ckan files.)
Cause
When we generate a modpack, installed DLC modules are included by default. This doesn't make sense because CKAN can't install DLC, and modpacks should be lists of mods for CKAN to install.
Changes
Now DLC appear in the Ignored list by default instead of Depends. If a user really wants them included in the pack, they can be moved to one of the other groups with the buttons. If any of the mods have a dependency on a DLC, this will already work normally.