No longer allow "install nothing" operations (#93). #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…empty. This closes KSP-CKAN#93. NB @AlexanderDzhoganov, we have another exception to watch for when installing.
Actually, it now uses `InstallModule()`, which does the work. Notable changes in this: - Install() can throw exceptions again. - We move InstallComponent() towards being deprecated - We cry over still needing bundles. - Closes KSP-CKAN#93 Sample output: ``` About to install... * DogeCoinFlag 1.03 Continue? [Y/N] DogeCoinFlag: Bad metadata detected for module DogeCoinFlag 1.03 No files found in GameData/DogeCoinFlag to install! ```
|
Rebased onto the new master branch, which means it's much easier to see what's going on now, because this is now only two commits. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93.
Includes #172 (which includes #171).
References #113.
See commit messages for further details.
dabd7a3 is sufficient for #93, but 7cb2807 results in nicer user output and architecture.