Skip to content

Commit

Permalink
Merge #4143 Make X skip buttons in changelog work better for modpacks
Browse files Browse the repository at this point in the history
  • Loading branch information
HebaruSan committed Aug 5, 2024
2 parents 1327aee + f2b71a7 commit 5b5911e
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ All notable changes to this project will be documented in this file.
- [Multiple] Alternate game command lines and Steam refactor (#4010, #4013, #4028 by: HebaruSan)
- [Multiple] Recommendations usability improvements (#4025 by: HebaruSan)
- [Multiple] Prompt for client upgrade when newer spec is found (#4026, #4057 by: HebaruSan)
- [GUI] Ability to clear auto-installed flag from changeset tab (#4033 by: HebaruSan)
- [GUI] Ability to clear auto-installed flag from changeset tab (#4033, #4143 by: HebaruSan)
- [Multiple] New Crowdin updates (#4019 by: Olympic1, vinix38; reviewed: HebaruSan)
- [Core] Support Windows KSP1 instances on Linux (#4044 by: HebaruSan)
- [GUI] I18n updates from Crowdin (#4050 by: HebaruSan)
Expand Down
2 changes: 2 additions & 0 deletions GUI/Controls/Changeset.cs
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ private void ChangesGrid_CellClick(object sender, DataGridViewCellEventArgs e)
&& row.Change.IsRemovable
&& row.ConfirmUncheck())
{
(ChangesGrid.DataSource as BindingList<ChangesetRow>)?.Remove(row);
changeset.Remove(row.Change);
OnRemoveItem?.Invoke(row.Change);
}
}
Expand Down
4 changes: 3 additions & 1 deletion GUI/Controls/ManageMods.cs
Original file line number Diff line number Diff line change
Expand Up @@ -963,7 +963,9 @@ private void guiModule_PropertyChanged(object sender, PropertyChangedEventArgs e

public void RemoveChangesetItem(ModChange change)
{
if (change.IsRemovable
if (currentChangeSet != null
&& currentChangeSet.Contains(change)
&& change.IsRemovable
&& mainModList.full_list_of_mod_rows.TryGetValue(change.Mod.identifier,
out DataGridViewRow row)
&& row.Tag is GUIMod guiMod)
Expand Down

0 comments on commit 5b5911e

Please sign in to comment.