seal PyAddToModule (PyO3#4606)

* seal PyAddToModule * adding change log * fix changelog name
KLMatlock · Oct 9, 2024 · 96da64b · 96da64b
1 parent 4cbf6e0
commit 96da64b
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/newsfragments/4606.changed.md b/newsfragments/4606.changed.md
@@ -0,0 +1 @@
+Seal `PyAddToModule` trait.
diff --git a/src/impl_/pymodule.rs b/src/impl_/pymodule.rs
@@ -144,7 +144,7 @@ impl ModuleDef {
 /// Trait to add an element (class, function...) to a module.
 ///
 /// Currently only implemented for classes.
-pub trait PyAddToModule {
+pub trait PyAddToModule: crate::sealed::Sealed {
     fn add_to_module(&'static self, module: &Bound<'_, PyModule>) -> PyResult<()>;
 }
 

diff --git a/src/sealed.rs b/src/sealed.rs
@@ -5,6 +5,11 @@ use crate::types::{
 };
 use crate::{ffi, Bound, PyAny, PyResult};
 
+use crate::impl_::{
+    pymethods::PyMethodDef,
+    pymodule::{AddClassToModule, AddTypeToModule, ModuleDef},
+};
+
 pub trait Sealed {}
 
 // for FfiPtrExt
@@ -36,3 +41,8 @@ impl Sealed for Bound<'_, PyType> {}
 impl Sealed for Bound<'_, PyWeakref> {}
 impl Sealed for Bound<'_, PyWeakrefProxy> {}
 impl Sealed for Bound<'_, PyWeakrefReference> {}
+
+impl<T> Sealed for AddTypeToModule<T> {}
+impl<T> Sealed for AddClassToModule<T> {}
+impl Sealed for PyMethodDef {}
+impl Sealed for ModuleDef {}