Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some inefficiencies in SQLite implementation #40

Open
wants to merge 1 commit into
base: offheap_upsert
Choose a base branch
from

Conversation

gortiz
Copy link

@gortiz gortiz commented Dec 19, 2023

This PR includes some improvements on SQLite implementation. I guess they could also be applied to H2, but being heap based, I don't think we care that much about H2.

With this changes results for sqlite went from 20 times slower than rocksdb to 30% faster:

Benchmark                                 (_keyCardinality)  (_metadataStoreType)  (_numRows)  (_numRuns)  (_numSegments)  Mode  Cnt    Score   Error  Units
BenchmarkUpsertAddRecord.upsertAddRecord            5000000               ROCKSDB        1000          10              10  avgt    2  237.424          ms/op
BenchmarkUpsertAddRecord.upsertAddRecord            5000000                SQLITE        1000          10              10  avgt    2  179.725          ms/op

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant