fix: PR feedback

KILTprotocol · Mar 15, 2019 · e8fa392 · e8fa392
1 parent a948405
commit e8fa392
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/runtime/src/attestation.rs b/runtime/src/attestation.rs
@@ -69,7 +69,7 @@ decl_module! {
 			let mut existing_attestations_for_claim = <Attestations<T>>::get(claim_hash.clone());
 			for v in existing_attestations_for_claim.iter_mut() {
 				if !v.3 {
-					if v.1.eq(&sender) && !v.3 {
+					if v.1.eq(&sender) {
 						last_attested = true;
 						v.3 = true;
 					} else {

diff --git a/runtime/src/delegation.rs b/runtime/src/delegation.rs
@@ -129,7 +129,7 @@ decl_module! {
                 return Err("not permitted to revoke")
             }
             if !r.2 {
-                r.2 = false;
+                r.2 = true;
                 <Root<T>>::insert(root_id.clone(), r);
                 Self::revoke_children(&root_id);
             }
@@ -172,7 +172,7 @@ impl<T: Trait> Module<T> {
     fn revoke(delegation: &T::DelegationNodeId) {
         let mut d = <Delegations<T>>::get(delegation.clone());
         if !d.4 {
-            d.4 = false;
+            d.4 = true;
             <Delegations<T>>::insert(delegation.clone(), d);
             Self::revoke_children(delegation);
         }